Skip to content

Commit 73b7b44

Browse files
Andrzej Hajdadaeinki
authored andcommitted
drm/exynos: simplify completion event handling
All Exynos CRTC drivers shouldn't fail at referencing vblank events, alternate path is actually dead code. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Signed-off-by: Inki Dae <inki.dae@samsung.com>
1 parent 9b43c16 commit 73b7b44

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

drivers/gpu/drm/exynos/exynos_drm_crtc.c

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -105,16 +105,15 @@ void exynos_crtc_handle_event(struct exynos_drm_crtc *exynos_crtc)
105105
struct drm_pending_vblank_event *event = crtc->state->event;
106106
unsigned long flags;
107107

108-
if (event) {
109-
crtc->state->event = NULL;
110-
spin_lock_irqsave(&crtc->dev->event_lock, flags);
111-
if (drm_crtc_vblank_get(crtc) == 0)
112-
drm_crtc_arm_vblank_event(crtc, event);
113-
else
114-
drm_crtc_send_vblank_event(crtc, event);
115-
spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
116-
}
108+
if (!event)
109+
return;
110+
crtc->state->event = NULL;
111+
112+
WARN_ON(drm_crtc_vblank_get(crtc) != 0);
117113

114+
spin_lock_irqsave(&crtc->dev->event_lock, flags);
115+
drm_crtc_arm_vblank_event(crtc, event);
116+
spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
118117
}
119118

120119
static void exynos_drm_crtc_destroy(struct drm_crtc *crtc)

0 commit comments

Comments
 (0)