wilc1000: Fix spurious "FW not responding" error

dmosberger · Kalle Valo · commit 73bbef64bca7 · 2021-12-14T20:45:27.000+02:00
When deinitializing the driver, one or more "FW not responding" error appears on the console. This appears to be due to wilc_wlan_stop() disabling host/WILC1000 communication, but then right afterwards, it tries to release the bus with chip-sleep enabled. The problem is enabling the chip-sleep cannot success once host/WILC1000 communication is disabled. Fix by only releasing the bus. Signed-off-by: David Mosberger-Tang <davidm@egauge.net> Signed-off-by: Kalle Valo <kvalo@kernel.org> Link: https://lore.kernel.org/r/20211208062747.3405221-1-davidm@egauge.net
diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/wireless/microchip/wilc1000/wlan.c
@@ -1224,7 +1224,8 @@ int wilc_wlan_stop(struct wilc *wilc, struct wilc_vif *vif)
 
 	ret = 0;
 release:
-	release_bus(wilc, WILC_BUS_RELEASE_ALLOW_SLEEP);
+	/* host comm is disabled - we can't issue sleep command anymore: */
+	release_bus(wilc, WILC_BUS_RELEASE_ONLY);
 
 	return ret;
 }

Original file line number	Diff line number	Diff line change
`@@ -1224,7 +1224,8 @@ int wilc_wlan_stop(struct wilc wilc, struct wilc_vif vif)`
`1224`	`1224`
`1225`	`1225`	`ret = 0;`
`1226`	`1226`	`release:`
`1227`		`- release_bus(wilc, WILC_BUS_RELEASE_ALLOW_SLEEP);`
	`1227`	`+ /* host comm is disabled - we can't issue sleep command anymore: */`
	`1228`	`+ release_bus(wilc, WILC_BUS_RELEASE_ONLY);`
`1228`	`1229`
`1229`	`1230`	`return ret;`
`1230`	`1231`	`}`