Skip to content

Commit 741c3ae

Browse files
pcornuAndrzej Hajda
authored andcommitted
drm/bridge/synopsys: dsi: use adjusted_mode in mode_set
The "adjusted_mode" clock value (ie the real pixel clock) is more accurate than "mode" clock value (ie the panel/bridge requested clock value). It offers a better preciseness for timing computations and allows to reduce the extra dsi bandwidth in burst mode (from ~20% to ~10-12%, hw platform dependent). Signed-off-by: Philippe Cornu <philippe.cornu@st.com> Tested-by: Brian Norris <briannorris@chromium.org> Reviewed-by: Yannick Fertré <yannick.fertre@st.com> Tested-by: Yannick Fertré <yannick.fertre@st.com> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180125155504.8611-1-philippe.cornu@st.com
1 parent 6649910 commit 741c3ae

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -771,20 +771,20 @@ static void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge,
771771

772772
clk_prepare_enable(dsi->pclk);
773773

774-
ret = phy_ops->get_lane_mbps(priv_data, mode, dsi->mode_flags,
774+
ret = phy_ops->get_lane_mbps(priv_data, adjusted_mode, dsi->mode_flags,
775775
dsi->lanes, dsi->format, &dsi->lane_mbps);
776776
if (ret)
777777
DRM_DEBUG_DRIVER("Phy get_lane_mbps() failed\n");
778778

779779
pm_runtime_get_sync(dsi->dev);
780780
dw_mipi_dsi_init(dsi);
781-
dw_mipi_dsi_dpi_config(dsi, mode);
781+
dw_mipi_dsi_dpi_config(dsi, adjusted_mode);
782782
dw_mipi_dsi_packet_handler_config(dsi);
783783
dw_mipi_dsi_video_mode_config(dsi);
784-
dw_mipi_dsi_video_packet_config(dsi, mode);
784+
dw_mipi_dsi_video_packet_config(dsi, adjusted_mode);
785785
dw_mipi_dsi_command_mode_config(dsi);
786-
dw_mipi_dsi_line_timer_config(dsi, mode);
787-
dw_mipi_dsi_vertical_timing_config(dsi, mode);
786+
dw_mipi_dsi_line_timer_config(dsi, adjusted_mode);
787+
dw_mipi_dsi_vertical_timing_config(dsi, adjusted_mode);
788788

789789
dw_mipi_dsi_dphy_init(dsi);
790790
dw_mipi_dsi_dphy_timing_config(dsi);
@@ -798,7 +798,7 @@ static void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge,
798798

799799
dw_mipi_dsi_dphy_enable(dsi);
800800

801-
dw_mipi_dsi_wait_for_two_frames(mode);
801+
dw_mipi_dsi_wait_for_two_frames(adjusted_mode);
802802

803803
/* Switch to cmd mode for panel-bridge pre_enable & panel prepare */
804804
dw_mipi_dsi_set_mode(dsi, 0);

0 commit comments

Comments
 (0)