y2038: __get_old_timespec32() can be static

kbuild test robot · arndb · commit 743f5cdb6cec · 2018-08-29T15:42:19.000+02:00
The kbuild test robot reports two new warnings with the previous patch: kernel/time/time.c:866:5: sparse: symbol '__get_old_timespec32' was not declared. Should it be static? kernel/time/time.c:882:5: sparse: symbol '__put_old_timespec32' was not declared. Should it be static? These are actually older bugs, but came up now after the symbol got renamed. Fortunately, commit afef05c ("time: Enable get/put_compat_itimerspec64 always") makes the two functions (__compat_get_timespec64/__compat_get_timespec64) local to time.c already, so we can mark them as 'static'. Fixes: ee16c8f ("y2038: Globally rename compat_time to old_time32") Signed-off-by: kbuild test robot <fengguang.wu@intel.com> [arnd: added changelog text] Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/kernel/time/time.c b/kernel/time/time.c
@@ -863,7 +863,7 @@ int put_timespec64(const struct timespec64 *ts,
 }
 EXPORT_SYMBOL_GPL(put_timespec64);
 
-int __get_old_timespec32(struct timespec64 *ts64,
+static int __get_old_timespec32(struct timespec64 *ts64,
 				   const struct old_timespec32 __user *cts)
 {
 	struct old_timespec32 ts;
@@ -879,7 +879,7 @@ int __get_old_timespec32(struct timespec64 *ts64,
 	return 0;
 }
 
-int __put_old_timespec32(const struct timespec64 *ts64,
+static int __put_old_timespec32(const struct timespec64 *ts64,
 				   struct old_timespec32 __user *cts)
 {
 	struct old_timespec32 ts = {

Original file line number	Diff line number	Diff line change
`@@ -863,7 +863,7 @@ int put_timespec64(const struct timespec64 *ts,`
`863`	`863`	`}`
`864`	`864`	`EXPORT_SYMBOL_GPL(put_timespec64);`
`865`	`865`
`866`		`-int __get_old_timespec32(struct timespec64 *ts64,`
	`866`	`+static int __get_old_timespec32(struct timespec64 *ts64,`
`867`	`867`	`const struct old_timespec32 __user *cts)`
`868`	`868`	`{`
`869`	`869`	`struct old_timespec32 ts;`
`@@ -879,7 +879,7 @@ int __get_old_timespec32(struct timespec64 *ts64,`
`879`	`879`	`return 0;`
`880`	`880`	`}`
`881`	`881`
`882`		`-int __put_old_timespec32(const struct timespec64 *ts64,`
	`882`	`+static int __put_old_timespec32(const struct timespec64 *ts64,`
`883`	`883`	`struct old_timespec32 __user *cts)`
`884`	`884`	`{`
`885`	`885`	`struct old_timespec32 ts = {`