Yama: use atomic allocations when reporting

sashalevin · kees · commit 74f430cd0fde · 2016-05-04T10:54:05.000-07:00
Access reporting often happens from atomic contexes. Avoid lockups when allocating memory for command lines. Fixes: 8a56038 ("Yama: consolidate error reporting") Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c
@@ -47,8 +47,8 @@ static void report_access(const char *access, struct task_struct *target,
 {
 	char *target_cmd, *agent_cmd;
 
-	target_cmd = kstrdup_quotable_cmdline(target, GFP_KERNEL);
-	agent_cmd = kstrdup_quotable_cmdline(agent, GFP_KERNEL);
+	target_cmd = kstrdup_quotable_cmdline(target, GFP_ATOMIC);
+	agent_cmd = kstrdup_quotable_cmdline(agent, GFP_ATOMIC);
 
 	pr_notice_ratelimited(
 		"ptrace %s of \"%s\"[%d] was attempted by \"%s\"[%d]\n",

Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,8 @@ static void report_access(const char access, struct task_struct target,`
`47`	`47`	`{`
`48`	`48`	`char target_cmd, agent_cmd;`
`49`	`49`
`50`		`- target_cmd = kstrdup_quotable_cmdline(target, GFP_KERNEL);`
`51`		`- agent_cmd = kstrdup_quotable_cmdline(agent, GFP_KERNEL);`
	`50`	`+ target_cmd = kstrdup_quotable_cmdline(target, GFP_ATOMIC);`
	`51`	`+ agent_cmd = kstrdup_quotable_cmdline(agent, GFP_ATOMIC);`
`52`	`52`
`53`	`53`	`pr_notice_ratelimited(`
`54`	`54`	`"ptrace %s of \"%s\"[%d] was attempted by \"%s\"[%d]\n",`