spi: bcm2835: Remove unnecessary workaround to call gpio_set_value

AxelLin · broonie · commit 763dedfcda5f · 2016-02-15T20:43:39.000Z
This should be fixed by commit 4c02cba ("pinctrl: bcm2835: Fix initial value for direction_output") Signed-off-by: Axel Lin <axel.lin@ingics.com> Acked-by: Martin Sperl <kernel@martin.sperl.org> Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c
@@ -727,11 +727,6 @@ static int bcm2835_spi_setup(struct spi_device *spi)
 			spi->chip_select, spi->cs_gpio, err);
 		return err;
 	}
-	/* the implementation of pinctrl-bcm2835 currently does not
-	 * set the GPIO value when using gpio_direction_output
-	 * so we are setting it here explicitly
-	 */
-	gpio_set_value(spi->cs_gpio, (spi->mode & SPI_CS_HIGH) ? 0 : 1);
 
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -727,11 +727,6 @@ static int bcm2835_spi_setup(struct spi_device *spi)`
`727`	`727`	`spi->chip_select, spi->cs_gpio, err);`
`728`	`728`	`return err;`
`729`	`729`	`}`
`730`		`- /* the implementation of pinctrl-bcm2835 currently does not`
`731`		`- * set the GPIO value when using gpio_direction_output`
`732`		`- * so we are setting it here explicitly`
`733`		`- */`
`734`		`- gpio_set_value(spi->cs_gpio, (spi->mode & SPI_CS_HIGH) ? 0 : 1);`
`735`	`730`
`736`	`731`	`return 0;`
`737`	`732`	`}`