i7core_edac: return -ENODEV when devices were already probed

Mauro Carvalho Chehab · Mauro Carvalho Chehab · commit 76a7bd811306 · 2010-10-24T11:36:19.000-02:00
Due to the nature of i7core, we need to probe and attach all PCI
devices used by this driver during the first time probe is called.
However, PCI core will call the probe routine one time for each CPU
socket. If we return -EINVAL to those calls, it would seem that the
driver fails, when, in fact, there's no more devices left to initialize.

Changing the return code to -ENODEV solves this issue.

Signed-off-by: Mauro Carvalho Chehab &lt;mchehab@redhat.com&gt;
diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c
@@ -2046,7 +2046,7 @@ static int __devinit i7core_probe(struct pci_dev *pdev,
 	 */
 	if (unlikely(probed >= 1)) {
 		mutex_unlock(&i7core_edac_lock);
-		return -EINVAL;
+		return -ENODEV;
 	}
 	probed++;
 

Original file line number	Diff line number	Diff line change
`@@ -2046,7 +2046,7 @@ static int __devinit i7core_probe(struct pci_dev *pdev,`
`2046`	`2046`	`*/`
`2047`	`2047`	`if (unlikely(probed >= 1)) {`
`2048`	`2048`	`mutex_unlock(&i7core_edac_lock);`
`2049`		`- return -EINVAL;`
	`2049`	`+ return -ENODEV;`
`2050`	`2050`	`}`
`2051`	`2051`	`probed++;`
`2052`	`2052`