Skip to content

Commit 7707e65

Browse files
robclarkairlied
authored andcommitted
drm/i915: use helpers
Signed-off-by: Rob Clark <robdclark@gmail.com> Signed-off-by: Dave Airlie <airlied@redhat.com>
1 parent 6d385c0 commit 7707e65

File tree

3 files changed

+12
-18
lines changed

3 files changed

+12
-18
lines changed

drivers/gpu/drm/i915/intel_display.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11738,21 +11738,20 @@ int intel_get_pipe_from_crtc_id(struct drm_device *dev, void *data,
1173811738
struct drm_file *file)
1173911739
{
1174011740
struct drm_i915_get_pipe_from_crtc_id *pipe_from_crtc_id = data;
11741-
struct drm_mode_object *drmmode_obj;
11741+
struct drm_crtc *drmmode_crtc;
1174211742
struct intel_crtc *crtc;
1174311743

1174411744
if (!drm_core_check_feature(dev, DRIVER_MODESET))
1174511745
return -ENODEV;
1174611746

11747-
drmmode_obj = drm_mode_object_find(dev, pipe_from_crtc_id->crtc_id,
11748-
DRM_MODE_OBJECT_CRTC);
11747+
drmmode_crtc = drm_crtc_find(dev, pipe_from_crtc_id->crtc_id);
1174911748

11750-
if (!drmmode_obj) {
11749+
if (!drmmode_crtc) {
1175111750
DRM_ERROR("no such CRTC id\n");
1175211751
return -ENOENT;
1175311752
}
1175411753

11755-
crtc = to_intel_crtc(obj_to_crtc(drmmode_obj));
11754+
crtc = to_intel_crtc(drmmode_crtc);
1175611755
pipe_from_crtc_id->pipe = crtc->pipe;
1175711756

1175811757
return 0;

drivers/gpu/drm/i915/intel_overlay.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1039,7 +1039,7 @@ int intel_overlay_put_image(struct drm_device *dev, void *data,
10391039
struct drm_intel_overlay_put_image *put_image_rec = data;
10401040
struct drm_i915_private *dev_priv = dev->dev_private;
10411041
struct intel_overlay *overlay;
1042-
struct drm_mode_object *drmmode_obj;
1042+
struct drm_crtc *drmmode_crtc;
10431043
struct intel_crtc *crtc;
10441044
struct drm_i915_gem_object *new_bo;
10451045
struct put_image_params *params;
@@ -1068,13 +1068,12 @@ int intel_overlay_put_image(struct drm_device *dev, void *data,
10681068
if (!params)
10691069
return -ENOMEM;
10701070

1071-
drmmode_obj = drm_mode_object_find(dev, put_image_rec->crtc_id,
1072-
DRM_MODE_OBJECT_CRTC);
1073-
if (!drmmode_obj) {
1071+
drmmode_crtc = drm_crtc_find(dev, put_image_rec->crtc_id);
1072+
if (!drmmode_crtc) {
10741073
ret = -ENOENT;
10751074
goto out_free;
10761075
}
1077-
crtc = to_intel_crtc(obj_to_crtc(drmmode_obj));
1076+
crtc = to_intel_crtc(drmmode_crtc);
10781077

10791078
new_bo = to_intel_bo(drm_gem_object_lookup(dev, file_priv,
10801079
put_image_rec->bo_handle));

drivers/gpu/drm/i915/intel_sprite.c

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1123,7 +1123,6 @@ int intel_sprite_set_colorkey(struct drm_device *dev, void *data,
11231123
struct drm_file *file_priv)
11241124
{
11251125
struct drm_intel_sprite_colorkey *set = data;
1126-
struct drm_mode_object *obj;
11271126
struct drm_plane *plane;
11281127
struct intel_plane *intel_plane;
11291128
int ret = 0;
@@ -1137,13 +1136,12 @@ int intel_sprite_set_colorkey(struct drm_device *dev, void *data,
11371136

11381137
drm_modeset_lock_all(dev);
11391138

1140-
obj = drm_mode_object_find(dev, set->plane_id, DRM_MODE_OBJECT_PLANE);
1141-
if (!obj) {
1139+
plane = drm_plane_find(dev, set->plane_id);
1140+
if (!plane) {
11421141
ret = -ENOENT;
11431142
goto out_unlock;
11441143
}
11451144

1146-
plane = obj_to_plane(obj);
11471145
intel_plane = to_intel_plane(plane);
11481146
ret = intel_plane->update_colorkey(plane, set);
11491147

@@ -1156,7 +1154,6 @@ int intel_sprite_get_colorkey(struct drm_device *dev, void *data,
11561154
struct drm_file *file_priv)
11571155
{
11581156
struct drm_intel_sprite_colorkey *get = data;
1159-
struct drm_mode_object *obj;
11601157
struct drm_plane *plane;
11611158
struct intel_plane *intel_plane;
11621159
int ret = 0;
@@ -1166,13 +1163,12 @@ int intel_sprite_get_colorkey(struct drm_device *dev, void *data,
11661163

11671164
drm_modeset_lock_all(dev);
11681165

1169-
obj = drm_mode_object_find(dev, get->plane_id, DRM_MODE_OBJECT_PLANE);
1170-
if (!obj) {
1166+
plane = drm_plane_find(dev, get->plane_id);
1167+
if (!plane) {
11711168
ret = -ENOENT;
11721169
goto out_unlock;
11731170
}
11741171

1175-
plane = obj_to_plane(obj);
11761172
intel_plane = to_intel_plane(plane);
11771173
intel_plane->get_colorkey(plane, get);
11781174

0 commit comments

Comments
 (0)