Skip to content

Commit 77ad0f2

Browse files
vireshkmripard
authored andcommitted
ARM: dts: sun8i-h3: Add missing cooling device properties for CPUs
The cooling device properties, like "#cooling-cells" and "dynamic-power-coefficient", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can register a cooling device. Add such missing properties. Fix other missing properties (clocks, clock-names) as well to make it all work. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
1 parent ce397d2 commit 77ad0f2

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

arch/arm/boot/dts/sun8i-h3.dtsi

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,21 +84,30 @@
8484
compatible = "arm,cortex-a7";
8585
device_type = "cpu";
8686
reg = <1>;
87+
clocks = <&ccu CLK_CPUX>;
88+
clock-names = "cpu";
8789
operating-points-v2 = <&cpu0_opp_table>;
90+
#cooling-cells = <2>;
8891
};
8992

9093
cpu@2 {
9194
compatible = "arm,cortex-a7";
9295
device_type = "cpu";
9396
reg = <2>;
97+
clocks = <&ccu CLK_CPUX>;
98+
clock-names = "cpu";
9499
operating-points-v2 = <&cpu0_opp_table>;
100+
#cooling-cells = <2>;
95101
};
96102

97103
cpu@3 {
98104
compatible = "arm,cortex-a7";
99105
device_type = "cpu";
100106
reg = <3>;
107+
clocks = <&ccu CLK_CPUX>;
108+
clock-names = "cpu";
101109
operating-points-v2 = <&cpu0_opp_table>;
110+
#cooling-cells = <2>;
102111
};
103112
};
104113

0 commit comments

Comments
 (0)