Skip to content

Commit 77ae0d8

Browse files
khfengJiri Kosina
authored andcommitted
HID: i2c-hid: Disable runtime PM on Goodix touchpad
A Goodix touchpad doesn't work. Touching the touchpad can trigger IRQ but there's no input event from HID subsystem. Turns out it reports some invalid data: [ 22.136630] i2c_hid i2c-DELL091F:00: input: 0b 00 01 00 00 00 00 00 00 00 00 After some trial and error, it's another device that doesn't work well with ON/SLEEP commands. Disable runtime PM to fix the issue. Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
1 parent ee46967 commit 77ae0d8

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

drivers/hid/hid-ids.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -461,6 +461,9 @@
461461
#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_010A 0x010a
462462
#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_E100 0xe100
463463

464+
#define I2C_VENDOR_ID_GOODIX 0x27c6
465+
#define I2C_DEVICE_ID_GOODIX_01F0 0x01f0
466+
464467
#define USB_VENDOR_ID_GOODTOUCH 0x1aad
465468
#define USB_DEVICE_ID_GOODTOUCH_000f 0x000f
466469

drivers/hid/i2c-hid/i2c-hid-core.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,8 @@ static const struct i2c_hid_quirks {
179179
I2C_HID_QUIRK_DELAY_AFTER_SLEEP },
180180
{ USB_VENDOR_ID_LG, I2C_DEVICE_ID_LG_8001,
181181
I2C_HID_QUIRK_NO_RUNTIME_PM },
182+
{ I2C_VENDOR_ID_GOODIX, I2C_DEVICE_ID_GOODIX_01F0,
183+
I2C_HID_QUIRK_NO_RUNTIME_PM },
182184
{ 0, 0 }
183185
};
184186

0 commit comments

Comments
 (0)