RDMA/mlx5: Initialize return variable in case pagefault was skipped

Leon Romanovsky · jgunthorpe · commit 7bca603a69c0 · 2018-11-29T15:16:45.000-07:00
Pagefaults occurred in non-ODP MR are completely valid events, so initialize return variable to 0. Fixes: 4d5422a ("IB/mlx5: Skip non-ODP MR when handling a page fault") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Leon Romanovsky <leonro@mellanox.com> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
diff --git a/drivers/infiniband/hw/mlx5/odp.c b/drivers/infiniband/hw/mlx5/odp.c
@@ -679,6 +679,7 @@ static int pagefault_single_data_segment(struct mlx5_ib_dev *dev,
 				    key);
 			if (bytes_mapped)
 				*bytes_mapped += bcnt;
+			ret = 0;
 			goto srcu_unlock;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -679,6 +679,7 @@ static int pagefault_single_data_segment(struct mlx5_ib_dev *dev,`
`679`	`679`	`key);`
`680`	`680`	`if (bytes_mapped)`
`681`	`681`	`*bytes_mapped += bcnt;`
	`682`	`+ ret = 0;`
`682`	`683`	`goto srcu_unlock;`
`683`	`684`	`}`
`684`	`685`