MIPS: Lantiq: Register IRQ handler for virtual IRQ number

hauke · ralfbaechle · commit 7bf0d5e8e643 · 2016-07-24T12:39:59.000+02:00
We used the hardware IRQ number to register the IRQ handler and not the virtual one. This probably caused some problems because the hardware IRQ numbers are only unique for each IRQ controller and not in the system. The virtual IRQ number is managed by Linux and unique in the system. This was probably the reason there was a gab of 8 IRQ numbers added before the numbers used for the lantiq IRQ controller. With the current setup the hardware and the virtual IRQ numbers are the same. Reported-by: Thomas Langer <thomas.langer@intel.com> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> Acked-by: John Crispin <john@phrozen.org> Cc: thomas.langer@intel.com Cc: linux-mips@linux-mips.org Patchwork: https://patchwork.linux-mips.org/patch/13539/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
diff --git a/arch/mips/lantiq/irq.c b/arch/mips/lantiq/irq.c
@@ -344,7 +344,7 @@ static int icu_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw)
 		if (hw == ltq_eiu_irq[i])
 			chip = &ltq_eiu_type;
 
-	irq_set_chip_and_handler(hw, chip, handle_level_irq);
+	irq_set_chip_and_handler(irq, chip, handle_level_irq);
 
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,7 @@ static int icu_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw)`
`344`	`344`	`if (hw == ltq_eiu_irq[i])`
`345`	`345`	`chip = &ltq_eiu_type;`
`346`	`346`
`347`		`- irq_set_chip_and_handler(hw, chip, handle_level_irq);`
	`347`	`+ irq_set_chip_and_handler(irq, chip, handle_level_irq);`
`348`	`348`
`349`	`349`	`return 0;`
`350`	`350`	`}`