Skip to content

Commit 7c8460d

Browse files
zhenywtorvalds
authored andcommitted
drm/i915: fix mask bits setting
eDP is exclusive connector too, and add missing crtc_mask setting for TV. This fixes http://bugzilla.kernel.org/show_bug.cgi?id=14139 Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com> Reported-and-tested-by: Carlos R. Mafra <crmafra2@gmail.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 3ff323f commit 7c8460d

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

drivers/gpu/drm/i915/intel_dp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1263,7 +1263,7 @@ intel_dp_init(struct drm_device *dev, int output_reg)
12631263

12641264
if (IS_eDP(intel_output)) {
12651265
intel_output->crtc_mask = (1 << 1);
1266-
intel_output->clone_mask = (1 << INTEL_OUTPUT_EDP);
1266+
intel_output->clone_mask = (1 << INTEL_EDP_CLONE_BIT);
12671267
} else
12681268
intel_output->crtc_mask = (1 << 0) | (1 << 1);
12691269
connector->interlace_allowed = true;

drivers/gpu/drm/i915/intel_drv.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@
7474
#define INTEL_LVDS_CLONE_BIT 14
7575
#define INTEL_DVO_TMDS_CLONE_BIT 15
7676
#define INTEL_DVO_LVDS_CLONE_BIT 16
77+
#define INTEL_EDP_CLONE_BIT 17
7778

7879
#define INTEL_DVO_CHIP_NONE 0
7980
#define INTEL_DVO_CHIP_LVDS 1

drivers/gpu/drm/i915/intel_tv.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1730,6 +1730,7 @@ intel_tv_init(struct drm_device *dev)
17301730
drm_mode_connector_attach_encoder(&intel_output->base, &intel_output->enc);
17311731
tv_priv = (struct intel_tv_priv *)(intel_output + 1);
17321732
intel_output->type = INTEL_OUTPUT_TVOUT;
1733+
intel_output->crtc_mask = (1 << 0) | (1 << 1);
17331734
intel_output->clone_mask = (1 << INTEL_TV_CLONE_BIT);
17341735
intel_output->enc.possible_crtcs = ((1 << 0) | (1 << 1));
17351736
intel_output->enc.possible_clones = (1 << INTEL_OUTPUT_TVOUT);

0 commit comments

Comments
 (0)