Skip to content

Commit 7d94610

Browse files
committed
ARM: dts: sun5i: Change LRADC node names to avoid warnings
One of the usage of the LRADC is to implement buttons. The bindings define that we should have one subnode per button, with their associated voltage as a property. However, there was no reg property but we still used the voltage associated to the button as the unit-address, which eventually generated warnings in DTC. Rename the node names to avoid those warnings. Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> Acked-by: Chen-Yu Tsai <wens@csie.org>
1 parent 39bfc23 commit 7d94610

File tree

6 files changed

+22
-22
lines changed

6 files changed

+22
-22
lines changed

arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -152,35 +152,35 @@
152152
vref-supply = <&reg_vcc3v0>;
153153
status = "okay";
154154

155-
button@191 {
155+
button-191 {
156156
label = "Volume Up";
157157
linux,code = <KEY_VOLUMEUP>;
158158
channel = <0>;
159159
voltage = <191274>;
160160
};
161161

162-
button@392 {
162+
button-392 {
163163
label = "Volume Down";
164164
linux,code = <KEY_VOLUMEDOWN>;
165165
channel = <0>;
166166
voltage = <392644>;
167167
};
168168

169-
button@601 {
169+
button-601 {
170170
label = "Menu";
171171
linux,code = <KEY_MENU>;
172172
channel = <0>;
173173
voltage = <601151>;
174174
};
175175

176-
button@795 {
176+
button-795 {
177177
label = "Enter";
178178
linux,code = <KEY_ENTER>;
179179
channel = <0>;
180180
voltage = <795090>;
181181
};
182182

183-
button@987 {
183+
button-987 {
184184
label = "Home";
185185
linux,code = <KEY_HOMEPAGE>;
186186
channel = <0>;

arch/arm/boot/dts/sun5i-a13-empire-electronix-d709.dts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,14 +105,14 @@
105105
vref-supply = <&reg_ldo2>;
106106
status = "okay";
107107

108-
button@200 {
108+
button-200 {
109109
label = "Volume Up";
110110
linux,code = <KEY_VOLUMEUP>;
111111
channel = <0>;
112112
voltage = <200000>;
113113
};
114114

115-
button@400 {
115+
button-400 {
116116
label = "Volume Down";
117117
linux,code = <KEY_VOLUMEDOWN>;
118118
channel = <0>;

arch/arm/boot/dts/sun5i-a13-hsg-h702.dts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,14 +100,14 @@
100100
vref-supply = <&reg_ldo2>;
101101
status = "okay";
102102

103-
button@200 {
103+
button-200 {
104104
label = "Volume Up";
105105
linux,code = <KEY_VOLUMEUP>;
106106
channel = <0>;
107107
voltage = <200000>;
108108
};
109109

110-
button@400 {
110+
button-400 {
111111
label = "Volume Down";
112112
linux,code = <KEY_VOLUMEDOWN>;
113113
channel = <0>;

arch/arm/boot/dts/sun5i-a13-licheepi-one.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@
124124
vref-supply = <&reg_ldo2>;
125125
status = "okay";
126126

127-
button@984 {
127+
button-984 {
128128
label = "Home";
129129
linux,code = <KEY_HOMEPAGE>;
130130
channel = <0>;

arch/arm/boot/dts/sun5i-a13-olinuxino.dts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -153,35 +153,35 @@
153153
vref-supply = <&reg_vcc3v0>;
154154
status = "okay";
155155

156-
button@191 {
156+
button-191 {
157157
label = "Volume Up";
158158
linux,code = <KEY_VOLUMEUP>;
159159
channel = <0>;
160160
voltage = <191274>;
161161
};
162162

163-
button@392 {
163+
button-392 {
164164
label = "Volume Down";
165165
linux,code = <KEY_VOLUMEDOWN>;
166166
channel = <0>;
167167
voltage = <392644>;
168168
};
169169

170-
button@601 {
170+
button-601 {
171171
label = "Menu";
172172
linux,code = <KEY_MENU>;
173173
channel = <0>;
174174
voltage = <601151>;
175175
};
176176

177-
button@795 {
177+
button-795 {
178178
label = "Enter";
179179
linux,code = <KEY_ENTER>;
180180
channel = <0>;
181181
voltage = <795090>;
182182
};
183183

184-
button@987 {
184+
button-987 {
185185
label = "Home";
186186
linux,code = <KEY_HOMEPAGE>;
187187
channel = <0>;

arch/arm/boot/dts/sun5i-gr8-evb.dts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -181,49 +181,49 @@
181181
vref-supply = <&reg_ldo2>;
182182
status = "okay";
183183

184-
button@190 {
184+
button-190 {
185185
label = "Volume Up";
186186
linux,code = <KEY_VOLUMEUP>;
187187
channel = <0>;
188188
voltage = <190000>;
189189
};
190190

191-
button@390 {
191+
button-390 {
192192
label = "Volume Down";
193193
linux,code = <KEY_VOLUMEDOWN>;
194194
channel = <0>;
195195
voltage = <390000>;
196196
};
197197

198-
button@600 {
198+
button-600 {
199199
label = "Menu";
200200
linux,code = <KEY_MENU>;
201201
channel = <0>;
202202
voltage = <600000>;
203203
};
204204

205-
button@800 {
205+
button-800 {
206206
label = "Search";
207207
linux,code = <KEY_SEARCH>;
208208
channel = <0>;
209209
voltage = <800000>;
210210
};
211211

212-
button@980 {
212+
button-980 {
213213
label = "Home";
214214
linux,code = <KEY_HOMEPAGE>;
215215
channel = <0>;
216216
voltage = <980000>;
217217
};
218218

219-
button@1180 {
219+
button-1180 {
220220
label = "Esc";
221221
linux,code = <KEY_ESC>;
222222
channel = <0>;
223223
voltage = <1180000>;
224224
};
225225

226-
button@1400 {
226+
button-1400 {
227227
label = "Enter";
228228
linux,code = <KEY_ENTER>;
229229
channel = <0>;

0 commit comments

Comments
 (0)