ide: unexport DISK_EVENT_MEDIA_CHANGE for ide-gd and ide-cd

htejun · Jens Axboe · commit 7eec77a1816a · 2011-04-21T19:43:59.000+02:00
check_events() implementations in both ide-gd and ide-cd are
inadequate for in-kernel event polling.  Both generate media change
events continuously when certain conditions are met causing infinite
event loop between the driver and userland event handler.

As disk event now supports suppression of unlisted events, simply
de-listing DISK_EVENT_MEDIA_CHANGE from disk-&gt;events resolves the
problem.  Internal handling around media revalidation will behave the
same while userland will fall back to userland event polling after
detecting the device doesn't support disk events.

Signed-off-by: Tejun Heo &lt;tj@kernel.org&gt;
Reported-by: Jens Axboe &lt;jaxboe@fusionio.com&gt;
Acked-by: "David S. Miller" &lt;davem@davemloft.net&gt;
Signed-off-by: Jens Axboe &lt;jaxboe@fusionio.com&gt;
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
@@ -1782,7 +1782,6 @@ static int ide_cd_probe(ide_drive_t *drive)
 	ide_cd_read_toc(drive, &sense);
 	g->fops = &idecd_ops;
 	g->flags |= GENHD_FL_REMOVABLE;
-	g->events = DISK_EVENT_MEDIA_CHANGE;
 	add_disk(g);
 	return 0;
 
diff --git a/drivers/ide/ide-cd_ioctl.c b/drivers/ide/ide-cd_ioctl.c
@@ -79,6 +79,12 @@ int ide_cdrom_drive_status(struct cdrom_device_info *cdi, int slot_nr)
 	return CDS_DRIVE_NOT_READY;
 }
 
+/*
+ * ide-cd always generates media changed event if media is missing, which
+ * makes it impossible to use for proper event reporting, so disk->events
+ * is cleared to 0 and the following function is used only to trigger
+ * revalidation and never propagated to userland.
+ */
 unsigned int ide_cdrom_check_events_real(struct cdrom_device_info *cdi,
 					 unsigned int clearing, int slot_nr)
 {
diff --git a/drivers/ide/ide-gd.c b/drivers/ide/ide-gd.c
@@ -298,6 +298,12 @@ static unsigned int ide_gd_check_events(struct gendisk *disk,
 		return 0;
 	}
 
+	/*
+	 * The following is used to force revalidation on the first open on
+	 * removeable devices, and never gets reported to userland as
+	 * genhd->events is 0.  This is intended as removeable ide disk
+	 * can't really detect MEDIA_CHANGE events.
+	 */
 	ret = drive->dev_flags & IDE_DFLAG_MEDIA_CHANGED;
 	drive->dev_flags &= ~IDE_DFLAG_MEDIA_CHANGED;
 
@@ -413,7 +419,6 @@ static int ide_gd_probe(ide_drive_t *drive)
 	if (drive->dev_flags & IDE_DFLAG_REMOVABLE)
 		g->flags = GENHD_FL_REMOVABLE;
 	g->fops = &ide_gd_ops;
-	g->events = DISK_EVENT_MEDIA_CHANGE;
 	add_disk(g);
 	return 0;
 

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,12 @@ int ide_cdrom_drive_status(struct cdrom_device_info *cdi, int slot_nr)`
`79`	`79`	`return CDS_DRIVE_NOT_READY;`
`80`	`80`	`}`
`81`	`81`
	`82`	`+/*`
	`83`	`+ * ide-cd always generates media changed event if media is missing, which`
	`84`	`+ * makes it impossible to use for proper event reporting, so disk->events`
	`85`	`+ * is cleared to 0 and the following function is used only to trigger`
	`86`	`+ * revalidation and never propagated to userland.`
	`87`	`+ */`
`82`	`88`	`unsigned int ide_cdrom_check_events_real(struct cdrom_device_info *cdi,`
`83`	`89`	`unsigned int clearing, int slot_nr)`
`84`	`90`	`{`