sched/deadline: Remove superfluous call to switched_to_dl()

Peter Zijlstra · Ingo Molnar · commit 801ccdbf018c · 2016-02-29T09:53:11.000+01:00
if (A || B) { } else if (A && !B) { } If A we'll take the first branch, if !A we will not satisfy the second. Therefore the second branch will never be taken. Reported-by: luca abeni <luca.abeni@unitn.it> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Juri Lelli <juri.lelli@arm.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20160225140149.GK6357@twins.programming.kicks-ass.net Signed-off-by: Ingo Molnar <mingo@kernel.org>
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
@@ -1772,8 +1772,7 @@ static void prio_changed_dl(struct rq *rq, struct task_struct *p,
 		 */
 		resched_curr(rq);
 #endif /* CONFIG_SMP */
-	} else
-		switched_to_dl(rq, p);
+	}
 }
 
 const struct sched_class dl_sched_class = {

Original file line number	Diff line number	Diff line change
`@@ -1772,8 +1772,7 @@ static void prio_changed_dl(struct rq rq, struct task_struct p,`
`1772`	`1772`	`*/`
`1773`	`1773`	`resched_curr(rq);`
`1774`	`1774`	`#endif /* CONFIG_SMP */`
`1775`		`- } else`
`1776`		`- switched_to_dl(rq, p);`
	`1775`	`+ }`
`1777`	`1776`	`}`
`1778`	`1777`
`1779`	`1778`	`const struct sched_class dl_sched_class = {`