net: hns3: Fix an error handling path in 'hclge_rss_init_hw()'

tititiou36 · davem330 · commit 81359617f1b7 · 2017-10-01T22:57:24.000-07:00
If this sanity check fails, we must free 'rss_indir'. Otherwise there is a memory leak. 'goto err' as done in the other error handling paths to fix it. Fixes: 46a3df9 ("net: hns3: Fix for setting rss_size incorrectly") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
@@ -2652,7 +2652,8 @@ static int hclge_rss_init_hw(struct hclge_dev *hdev)
 		dev_err(&hdev->pdev->dev,
 			"Configure rss tc size failed, invalid TC_SIZE = %d\n",
 			rss_size);
-		return -EINVAL;
+		ret = -EINVAL;
+		goto err;
 	}
 
 	roundup_size = roundup_pow_of_two(rss_size);

Original file line number	Diff line number	Diff line change
`@@ -2652,7 +2652,8 @@ static int hclge_rss_init_hw(struct hclge_dev *hdev)`
`2652`	`2652`	`dev_err(&hdev->pdev->dev,`
`2653`	`2653`	`"Configure rss tc size failed, invalid TC_SIZE = %d\n",`
`2654`	`2654`	`rss_size);`
`2655`		`- return -EINVAL;`
	`2655`	`+ ret = -EINVAL;`
	`2656`	`+ goto err;`
`2656`	`2657`	`}`
`2657`	`2658`
`2658`	`2659`	`roundup_size = roundup_pow_of_two(rss_size);`