HID: hidraw: fix power sequence when closing device

dtor · Jiri Kosina · commit 814b6d17487f · 2017-10-02T11:46:31.000+02:00
We should not try to bring HID device out of full power state before
calling hid_hw_close(), so that transport driver operates on powered up
device (making this inverse of the opening sequence).

Signed-off-by: Dmitry Torokhov &lt;dmitry.torokhov@gmail.com&gt;
Reviewed-by: Guenter Roeck &lt;groeck@chromium.org&gt;
Reviewed-by: Benson Leung &lt;bleung@chromium.org&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.cz&gt;
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
@@ -337,8 +337,8 @@ static void drop_ref(struct hidraw *hidraw, int exists_bit)
 			kfree(hidraw);
 		} else {
 			/* close device for last reader */
-			hid_hw_power(hidraw->hid, PM_HINT_NORMAL);
 			hid_hw_close(hidraw->hid);
+			hid_hw_power(hidraw->hid, PM_HINT_NORMAL);
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -337,8 +337,8 @@ static void drop_ref(struct hidraw *hidraw, int exists_bit)`
`337`	`337`	`kfree(hidraw);`
`338`	`338`	`} else {`
`339`	`339`	`/* close device for last reader */`
`340`		`- hid_hw_power(hidraw->hid, PM_HINT_NORMAL);`
`341`	`340`	`hid_hw_close(hidraw->hid);`
	`341`	`+ hid_hw_power(hidraw->hid, PM_HINT_NORMAL);`
`342`	`342`	`}`
`343`	`343`	`}`
`344`	`344`	`}`