usb: gadget: rndis: use signed type for a signed value

Andrzej Pietrasiewicz · Felipe Balbi · commit 81dff8692865 · 2015-05-21T16:29:14.000-05:00
rndis_get_nr() returns either a non-negative value on success
or a negative value on failure. In case of failure an error code
is returned to the caller of rndis_register().
If the "i" is unsigned, the information about error from rndis_get_nr()
is lost. If there is no error but rndis_get_nr() returns a value greater
than 256 the least significant bits of i are zero effectively limiting the
number of configs to 256.

This patch fixes that.

Signed-off-by: Andrzej Pietrasiewicz &lt;andrzej.p@samsung.com&gt;
Signed-off-by: Felipe Balbi &lt;balbi@ti.com&gt;
diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c
@@ -872,7 +872,7 @@ static inline void rndis_put_nr(int nr)
 struct rndis_params *rndis_register(void (*resp_avail)(void *v), void *v)
 {
 	struct rndis_params *params;
-	u8 i;
+	int i;
 
 	if (!resp_avail)
 		return ERR_PTR(-EINVAL);
@@ -923,7 +923,7 @@ EXPORT_SYMBOL_GPL(rndis_register);
 
 void rndis_deregister(struct rndis_params *params)
 {
-	u8 i;
+	int i;
 
 	pr_debug("%s:\n", __func__);
 
diff --git a/drivers/usb/gadget/function/rndis.h b/drivers/usb/gadget/function/rndis.h
@@ -177,7 +177,7 @@ typedef struct rndis_resp_t
 
 typedef struct rndis_params
 {
-	u8			confignr;
+	int			confignr;
 	u8			used;
 	u16			saved_filter;
 	enum rndis_state	state;

Original file line number	Diff line number	Diff line change
`@@ -872,7 +872,7 @@ static inline void rndis_put_nr(int nr)`
`872`	`872`	`struct rndis_params rndis_register(void (resp_avail)(void v), void v)`
`873`	`873`	`{`
`874`	`874`	`struct rndis_params *params;`
`875`		`- u8 i;`
	`875`	`+ int i;`
`876`	`876`
`877`	`877`	`if (!resp_avail)`
`878`	`878`	`return ERR_PTR(-EINVAL);`
`@@ -923,7 +923,7 @@ EXPORT_SYMBOL_GPL(rndis_register);`
`923`	`923`
`924`	`924`	`void rndis_deregister(struct rndis_params *params)`
`925`	`925`	`{`
`926`		`- u8 i;`
	`926`	`+ int i;`
`927`	`927`
`928`	`928`	`pr_debug("%s:\n", __func__);`
`929`	`929`
Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ typedef struct rndis_resp_t`
`177`	`177`
`178`	`178`	`typedef struct rndis_params`
`179`	`179`	`{`
`180`		`- u8 confignr;`
	`180`	`+ int confignr;`
`181`	`181`	`u8 used;`
`182`	`182`	`u16 saved_filter;`
`183`	`183`	`enum rndis_state state;`