media: tvp5150: fix irq_request error path during probe

Marco Felsch · mchehab · commit 81fd5fd46ec9 · 2018-12-05T04:40:10.000-05:00
Commit 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling")
introduced the interrupt handling. But we have to free the
v4l2_ctrl_handler before we can return the error code.

Fixes: 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling")

Signed-off-by: Marco Felsch &lt;m.felsch@pengutronix.de&gt;
Reviewed-by: Laurent Pinchart &lt;laurent.pinchart@ideasonboard.com&gt;
Signed-off-by: Mauro Carvalho Chehab &lt;mchehab+samsung@kernel.org&gt;
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
@@ -1790,7 +1790,7 @@ static int tvp5150_probe(struct i2c_client *c,
 						tvp5150_isr, IRQF_TRIGGER_HIGH |
 						IRQF_ONESHOT, "tvp5150", core);
 		if (res)
-			return res;
+			goto err;
 	}
 
 	res = v4l2_async_register_subdev(sd);

Original file line number	Diff line number	Diff line change
`@@ -1790,7 +1790,7 @@ static int tvp5150_probe(struct i2c_client *c,`
`1790`	`1790`	`tvp5150_isr, IRQF_TRIGGER_HIGH \|`
`1791`	`1791`	`IRQF_ONESHOT, "tvp5150", core);`
`1792`	`1792`	`if (res)`
`1793`		`- return res;`
	`1793`	`+ goto err;`
`1794`	`1794`	`}`
`1795`	`1795`
`1796`	`1796`	`res = v4l2_async_register_subdev(sd);`