Skip to content

Commit 8212c98

Browse files
ffainellidavem330
authored andcommitted
net: bcmgenet: rename bcmgenet_ephy_power_up
In preparation for implementing the power down GPHY sequence, rename bcmgenet_ephy_power_up to illustrate that it is not EPHY specific but PHY agnostic, and add an "enable" argument. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 0d017e2 commit 8212c98

File tree

1 file changed

+13
-11
lines changed
  • drivers/net/ethernet/broadcom/genet

1 file changed

+13
-11
lines changed

drivers/net/ethernet/broadcom/genet/bcmmii.c

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ void bcmgenet_mii_reset(struct net_device *dev)
168168
}
169169
}
170170

171-
static void bcmgenet_ephy_power_up(struct net_device *dev)
171+
static void bcmgenet_phy_power_set(struct net_device *dev, bool enable)
172172
{
173173
struct bcmgenet_priv *priv = netdev_priv(dev);
174174
u32 reg = 0;
@@ -177,24 +177,26 @@ static void bcmgenet_ephy_power_up(struct net_device *dev)
177177
if (!GENET_IS_V4(priv))
178178
return;
179179

180-
reg = bcmgenet_ext_readl(priv, EXT_GPHY_CTRL);
181-
reg &= ~(EXT_CFG_IDDQ_BIAS | EXT_CFG_PWR_DOWN | EXT_CK25_DIS);
182-
reg |= EXT_GPHY_RESET;
183-
bcmgenet_ext_writel(priv, reg, EXT_GPHY_CTRL);
184-
mdelay(2);
180+
if (enable) {
181+
reg = bcmgenet_ext_readl(priv, EXT_GPHY_CTRL);
182+
reg &= ~(EXT_CFG_IDDQ_BIAS | EXT_CFG_PWR_DOWN | EXT_CK25_DIS);
183+
reg |= EXT_GPHY_RESET;
184+
bcmgenet_ext_writel(priv, reg, EXT_GPHY_CTRL);
185+
mdelay(2);
185186

186-
reg &= ~EXT_GPHY_RESET;
187-
bcmgenet_ext_writel(priv, reg, EXT_GPHY_CTRL);
188-
udelay(20);
187+
reg &= ~EXT_GPHY_RESET;
188+
bcmgenet_ext_writel(priv, reg, EXT_GPHY_CTRL);
189+
udelay(20);
190+
}
189191
}
190192

191193
static void bcmgenet_internal_phy_setup(struct net_device *dev)
192194
{
193195
struct bcmgenet_priv *priv = netdev_priv(dev);
194196
u32 reg;
195197

196-
/* Power up EPHY */
197-
bcmgenet_ephy_power_up(dev);
198+
/* Power up PHY */
199+
bcmgenet_phy_power_set(dev, true);
198200
/* enable APD */
199201
reg = bcmgenet_ext_readl(priv, EXT_EXT_PWR_MGMT);
200202
reg |= EXT_PWR_DN_EN_LD;

0 commit comments

Comments
 (0)