ARM: 8522/1: drivers: nvdimm: ensure no negative value gets returned on positive match

djbw · Russell King · commit 82ec2ba2b181 · 2016-02-16T16:28:50.000Z
This patch ensures that existing bus match callbacks don't return
negative values (which might be interpreted as potential errors in the
future) in case of positive match.

Signed-off-by: Dan Williams &lt;dan.j.williams@intel.com&gt;
Signed-off-by: Marek Szyprowski &lt;m.szyprowski@samsung.com&gt;
Signed-off-by: Russell King &lt;rmk+kernel@arm.linux.org.uk&gt;
diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
@@ -62,7 +62,7 @@ static int nvdimm_bus_match(struct device *dev, struct device_driver *drv)
 {
 	struct nd_device_driver *nd_drv = to_nd_device_driver(drv);
 
-	return test_bit(to_nd_device_type(dev), &nd_drv->type);
+	return !!test_bit(to_nd_device_type(dev), &nd_drv->type);
 }
 
 static struct module *to_bus_provider(struct device *dev)

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ static int nvdimm_bus_match(struct device dev, struct device_driver drv)`
`62`	`62`	`{`
`63`	`63`	`struct nd_device_driver *nd_drv = to_nd_device_driver(drv);`
`64`	`64`
`65`		`- return test_bit(to_nd_device_type(dev), &nd_drv->type);`
	`65`	`+ return !!test_bit(to_nd_device_type(dev), &nd_drv->type);`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`static struct module to_bus_provider(struct device dev)`