sctp: remove useless start_fail from sctp_ht_iter in proc

lxin · davem330 · commit 834539e69a5f · 2018-08-27T15:13:17.000-07:00
After changing rhashtable_walk_start to return void, start_fail would never be set other value than 0, and the checking for start_fail is pointless, so remove it. Fixes: 97a6ec4 ("rhashtable: Change rhashtable_walk_start to return void") Signed-off-by: Xin Long <lucien.xin@gmail.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/sctp/proc.c b/net/sctp/proc.c
@@ -215,7 +215,6 @@ static const struct seq_operations sctp_eps_ops = {
 struct sctp_ht_iter {
 	struct seq_net_private p;
 	struct rhashtable_iter hti;
-	int start_fail;
 };
 
 static void *sctp_transport_seq_start(struct seq_file *seq, loff_t *pos)
@@ -224,16 +223,13 @@ static void *sctp_transport_seq_start(struct seq_file *seq, loff_t *pos)
 
 	sctp_transport_walk_start(&iter->hti);
 
-	iter->start_fail = 0;
 	return sctp_transport_get_idx(seq_file_net(seq), &iter->hti, *pos);
 }
 
 static void sctp_transport_seq_stop(struct seq_file *seq, void *v)
 {
 	struct sctp_ht_iter *iter = seq->private;
 
-	if (iter->start_fail)
-		return;
 	sctp_transport_walk_stop(&iter->hti);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,6 @@ static const struct seq_operations sctp_eps_ops = {`
`215`	`215`	`struct sctp_ht_iter {`
`216`	`216`	`struct seq_net_private p;`
`217`	`217`	`struct rhashtable_iter hti;`
`218`		`- int start_fail;`
`219`	`218`	`};`
`220`	`219`
`221`	`220`	`static void sctp_transport_seq_start(struct seq_file seq, loff_t *pos)`
`@@ -224,16 +223,13 @@ static void sctp_transport_seq_start(struct seq_file seq, loff_t *pos)`
`224`	`223`
`225`	`224`	`sctp_transport_walk_start(&iter->hti);`
`226`	`225`
`227`		`- iter->start_fail = 0;`
`228`	`226`	`return sctp_transport_get_idx(seq_file_net(seq), &iter->hti, *pos);`
`229`	`227`	`}`
`230`	`228`
`231`	`229`	`static void sctp_transport_seq_stop(struct seq_file seq, void v)`
`232`	`230`	`{`
`233`	`231`	`struct sctp_ht_iter *iter = seq->private;`
`234`	`232`
`235`		`- if (iter->start_fail)`
`236`		`- return;`
`237`	`233`	`sctp_transport_walk_stop(&iter->hti);`
`238`	`234`	`}`
`239`	`235`