irqchip/gic: Loudly complain about the use of IRQ_TYPE_NONE

Marc Zyngier · Marc Zyngier · commit 83a86fbb5b56 · 2018-03-16T14:35:17.000Z
There is a huge number of broken device trees out there. Just
grepping through the tree for the use of IRQ_TYPE_NONE in conjunction
with the GIC is scary.

People just don't realise that IRQ_TYPE_NONE just doesn't exist, and
you just get whatever junk was there before. So let's make them aware
of the issue.

Signed-off-by: Marc Zyngier &lt;marc.zyngier@arm.com&gt;
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
@@ -1011,6 +1011,9 @@ static int gic_irq_domain_translate(struct irq_domain *d,
 			*hwirq += 16;
 
 		*type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
+
+		/* Make it clear that broken DTs are... broken */
+		WARN_ON(*type == IRQ_TYPE_NONE);
 		return 0;
 	}
 
@@ -1020,6 +1023,8 @@ static int gic_irq_domain_translate(struct irq_domain *d,
 
 		*hwirq = fwspec->param[0];
 		*type = fwspec->param[1];
+
+		WARN_ON(*type == IRQ_TYPE_NONE);
 		return 0;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1011,6 +1011,9 @@ static int gic_irq_domain_translate(struct irq_domain *d,`
`1011`	`1011`	`*hwirq += 16;`
`1012`	`1012`
`1013`	`1013`	`*type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;`
	`1014`	`+`
	`1015`	`+ /* Make it clear that broken DTs are... broken */`
	`1016`	`+ WARN_ON(*type == IRQ_TYPE_NONE);`
`1014`	`1017`	`return 0;`
`1015`	`1018`	`}`
`1016`	`1019`
`@@ -1020,6 +1023,8 @@ static int gic_irq_domain_translate(struct irq_domain *d,`
`1020`	`1023`
`1021`	`1024`	`*hwirq = fwspec->param[0];`
`1022`	`1025`	`*type = fwspec->param[1];`
	`1026`	`+`
	`1027`	`+ WARN_ON(*type == IRQ_TYPE_NONE);`
`1023`	`1028`	`return 0;`
`1024`	`1029`	`}`
`1025`	`1030`