tools/power x86_energy_perf_policy: close /proc/stat in for_every_cpu()

Colin Ian King · lenb · commit 84764a415c70 · 2012-11-30T01:09:44.000-05:00
Instead of returning out of for_every_cpu() we should break out of the loop=
 which will then tidy up correctly by closing the file /proc/stat.

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
@@ -289,7 +289,7 @@ void for_every_cpu(void (func)(int))
 			"cpu%u %*d %*d %*d %*d %*d %*d %*d %*d %*d %*d\n",
 			&cpu);
 		if (retval != 1)
-			return;
+			break;
 
 		func(cpu);
 	}

Original file line number	Diff line number	Diff line change
`@@ -289,7 +289,7 @@ void for_every_cpu(void (func)(int))`
`289`	`289`	`"cpu%u %d %d %d %d %d %d %d %d %d %d\n",`
`290`	`290`	`&cpu);`
`291`	`291`	`if (retval != 1)`
`292`		`- return;`
	`292`	`+ break;`
`293`	`293`
`294`	`294`	`func(cpu);`
`295`	`295`	`}`