Skip to content

Commit 84bd8d3

Browse files
committed
Merge tag 'trace-v4.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace
Pull tracing fix from Steven Rostedt: "Fix tick_stop tracepoint symbols for user export. Luiz Capitulino noticed that the tick_stop tracepoint wasn't being parsed properly by the tracing user space tools. This was due to the TRACE_DEFINE_ENUM() being set to a define, when it should have been set to the enum itself. The define was of the MASK that used the BIT to shift. The BIT was the enum and by adding that, everything gets converted nicely. The MASK is still kept just in case it gets converted to an enum in the future" * tag 'trace-v4.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace: tracing: Fix tick_stop tracepoint symbols for user export
2 parents b79f34d + c87edb3 commit 84bd8d3

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

include/trace/events/timer.h

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -330,24 +330,32 @@ TRACE_EVENT(itimer_expire,
330330
#ifdef CONFIG_NO_HZ_COMMON
331331

332332
#define TICK_DEP_NAMES \
333-
tick_dep_name(NONE) \
333+
tick_dep_mask_name(NONE) \
334334
tick_dep_name(POSIX_TIMER) \
335335
tick_dep_name(PERF_EVENTS) \
336336
tick_dep_name(SCHED) \
337337
tick_dep_name_end(CLOCK_UNSTABLE)
338338

339339
#undef tick_dep_name
340+
#undef tick_dep_mask_name
340341
#undef tick_dep_name_end
341342

342-
#define tick_dep_name(sdep) TRACE_DEFINE_ENUM(TICK_DEP_MASK_##sdep);
343-
#define tick_dep_name_end(sdep) TRACE_DEFINE_ENUM(TICK_DEP_MASK_##sdep);
343+
/* The MASK will convert to their bits and they need to be processed too */
344+
#define tick_dep_name(sdep) TRACE_DEFINE_ENUM(TICK_DEP_BIT_##sdep); \
345+
TRACE_DEFINE_ENUM(TICK_DEP_MASK_##sdep);
346+
#define tick_dep_name_end(sdep) TRACE_DEFINE_ENUM(TICK_DEP_BIT_##sdep); \
347+
TRACE_DEFINE_ENUM(TICK_DEP_MASK_##sdep);
348+
/* NONE only has a mask defined for it */
349+
#define tick_dep_mask_name(sdep) TRACE_DEFINE_ENUM(TICK_DEP_MASK_##sdep);
344350

345351
TICK_DEP_NAMES
346352

347353
#undef tick_dep_name
354+
#undef tick_dep_mask_name
348355
#undef tick_dep_name_end
349356

350357
#define tick_dep_name(sdep) { TICK_DEP_MASK_##sdep, #sdep },
358+
#define tick_dep_mask_name(sdep) { TICK_DEP_MASK_##sdep, #sdep },
351359
#define tick_dep_name_end(sdep) { TICK_DEP_MASK_##sdep, #sdep }
352360

353361
#define show_tick_dep_name(val) \

0 commit comments

Comments
 (0)