cgroup: use strscpy() is more robust and safer

ye xingchen · htejun · commit 8619e94d3be3 · 2022-09-23T17:27:02.000-10:00
The implementation of strscpy() is more robust and safer.

That's now the recommended way to copy NUL terminated strings.

Signed-off-by: ye xingchen &lt;ye.xingchen@zte.com.cn&gt;
Signed-off-by: Tejun Heo &lt;tj@kernel.org&gt;
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
@@ -2374,7 +2374,7 @@ int task_cgroup_path(struct task_struct *task, char *buf, size_t buflen)
 		ret = cgroup_path_ns_locked(cgrp, buf, buflen, &init_cgroup_ns);
 	} else {
 		/* if no hierarchy exists, everyone is in "/" */
-		ret = strlcpy(buf, "/", buflen);
+		ret = strscpy(buf, "/", buflen);
 	}
 
 	spin_unlock_irq(&css_set_lock);

Original file line number	Diff line number	Diff line change
`@@ -2374,7 +2374,7 @@ int task_cgroup_path(struct task_struct task, char buf, size_t buflen)`
`2374`	`2374`	`ret = cgroup_path_ns_locked(cgrp, buf, buflen, &init_cgroup_ns);`
`2375`	`2375`	`} else {`
`2376`	`2376`	`/* if no hierarchy exists, everyone is in "/" */`
`2377`		`- ret = strlcpy(buf, "/", buflen);`
	`2377`	`+ ret = strscpy(buf, "/", buflen);`
`2378`	`2378`	`}`
`2379`	`2379`
`2380`	`2380`	`spin_unlock_irq(&css_set_lock);`