usb: dwc3: gadget: return error if command sent to DGCMD register fails

Sundeep-Bhatta · Felipe Balbi · commit 891b1dc02295 · 2015-05-26T10:39:23.000-05:00
We need to return error to caller if command is not sent to controller succesfully. Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com> Fixes: b09bb64 (usb: dwc3: gadget: implement Global Command support) Cc: <stable@vger.kernel.org> #v3.5+ Signed-off-by: Felipe Balbi <balbi@ti.com>
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
@@ -291,6 +291,8 @@ int dwc3_send_gadget_generic_command(struct dwc3 *dwc, unsigned cmd, u32 param)
 			dwc3_trace(trace_dwc3_gadget,
 					"Command Complete --> %d",
 					DWC3_DGCMD_STATUS(reg));
+			if (DWC3_DGCMD_STATUS(reg))
+				return -EINVAL;
 			return 0;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -291,6 +291,8 @@ int dwc3_send_gadget_generic_command(struct dwc3 *dwc, unsigned cmd, u32 param)`
`291`	`291`	`dwc3_trace(trace_dwc3_gadget,`
`292`	`292`	`"Command Complete --> %d",`
`293`	`293`	`DWC3_DGCMD_STATUS(reg));`
	`294`	`+ if (DWC3_DGCMD_STATUS(reg))`
	`295`	`+ return -EINVAL;`
`294`	`296`	`return 0;`
`295`	`297`	`}`
`296`	`298`