scsi: target/core: Use kmem_cache_free() instead of kfree()

Wei Yongjun · martinkpetersen · commit 8b2db98e814a · 2018-12-18T22:52:14.000-05:00
memory allocated by kmem_cache_alloc() should be freed using kmem_cache_free(), not kfree(). Fixes: ad66950 ("scsi: target/core: Make sure that target_wait_for_sess_cmds() waits long enough") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
@@ -266,7 +266,7 @@ struct se_session *transport_alloc_session(enum target_prot_op sup_prot_ops)
 	}
 	ret = transport_init_session(se_sess);
 	if (ret < 0) {
-		kfree(se_sess);
+		kmem_cache_free(se_sess_cache, se_sess);
 		return ERR_PTR(ret);
 	}
 	se_sess->sup_prot_ops = sup_prot_ops;

Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,7 @@ struct se_session *transport_alloc_session(enum target_prot_op sup_prot_ops)`
`266`	`266`	`}`
`267`	`267`	`ret = transport_init_session(se_sess);`
`268`	`268`	`if (ret < 0) {`
`269`		`- kfree(se_sess);`
	`269`	`+ kmem_cache_free(se_sess_cache, se_sess);`
`270`	`270`	`return ERR_PTR(ret);`
`271`	`271`	`}`
`272`	`272`	`se_sess->sup_prot_ops = sup_prot_ops;`