i2c: bcm-iproc: Use complete() instead of complete_all()

Daniel Wagner · Wolfram Sang · commit 8d263be8716d · 2016-08-15T00:55:31.000+02:00
There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().

The usage pattern of the completion is:

bcm_iproc_i2c_xfer_single_msg()
  reinit_completion()
  ...
  (activate the transfer)
  ...
  wait_for_completion_timeout()

Signed-off-by: Daniel Wagner &lt;daniel.wagner@bmw-carit.de&gt;
Acked-by: Ray Jui &lt;ray.jui@broadcom.com&gt;
Signed-off-by: Wolfram Sang &lt;wsa@the-dreams.de&gt;
diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c
@@ -158,7 +158,7 @@ static irqreturn_t bcm_iproc_i2c_isr(int irq, void *data)
 
 	if (status & BIT(IS_M_START_BUSY_SHIFT)) {
 		iproc_i2c->xfer_is_done = 1;
-		complete_all(&iproc_i2c->done);
+		complete(&iproc_i2c->done);
 	}
 
 	writel(status, iproc_i2c->base + IS_OFFSET);

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ static irqreturn_t bcm_iproc_i2c_isr(int irq, void *data)`
`158`	`158`
`159`	`159`	`if (status & BIT(IS_M_START_BUSY_SHIFT)) {`
`160`	`160`	`iproc_i2c->xfer_is_done = 1;`
`161`		`- complete_all(&iproc_i2c->done);`
	`161`	`+ complete(&iproc_i2c->done);`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`writel(status, iproc_i2c->base + IS_OFFSET);`