PCI/MSI: Return -ENOSYS for unimplemented interfaces, not -1

Alexander Gordeev · bjorn-helgaas · commit 8ec5db6b20c8 · 2013-12-20T09:45:05.000-07:00
Suggested-by: Ben Hutchings &lt;bhutchings@solarflare.com&gt;
Signed-off-by: Alexander Gordeev &lt;agordeev@redhat.com&gt;
Signed-off-by: Bjorn Helgaas &lt;bhelgaas@google.com&gt;
Reviewed-by: Tejun Heo &lt;tj@kernel.org&gt;
diff --git a/include/linux/pci.h b/include/linux/pci.h
@@ -1156,13 +1156,13 @@ struct msix_entry {
 #ifndef CONFIG_PCI_MSI
 static inline int pci_enable_msi_block(struct pci_dev *dev, unsigned int nvec)
 {
-	return -1;
+	return -ENOSYS;
 }
 
 static inline int
 pci_enable_msi_block_auto(struct pci_dev *dev, unsigned int *maxvec)
 {
-	return -1;
+	return -ENOSYS;
 }
 
 static inline void pci_msi_shutdown(struct pci_dev *dev)
@@ -1177,7 +1177,7 @@ static inline int pci_msix_table_size(struct pci_dev *dev)
 static inline int pci_enable_msix(struct pci_dev *dev,
 				  struct msix_entry *entries, int nvec)
 {
-	return -1;
+	return -ENOSYS;
 }
 
 static inline void pci_msix_shutdown(struct pci_dev *dev)

Original file line number	Diff line number	Diff line change
`@@ -1156,13 +1156,13 @@ struct msix_entry {`
`1156`	`1156`	`#ifndef CONFIG_PCI_MSI`
`1157`	`1157`	`static inline int pci_enable_msi_block(struct pci_dev *dev, unsigned int nvec)`
`1158`	`1158`	`{`
`1159`		`- return -1;`
	`1159`	`+ return -ENOSYS;`
`1160`	`1160`	`}`
`1161`	`1161`
`1162`	`1162`	`static inline int`
`1163`	`1163`	`pci_enable_msi_block_auto(struct pci_dev dev, unsigned int maxvec)`
`1164`	`1164`	`{`
`1165`		`- return -1;`
	`1165`	`+ return -ENOSYS;`
`1166`	`1166`	`}`
`1167`	`1167`
`1168`	`1168`	`static inline void pci_msi_shutdown(struct pci_dev *dev)`
`@@ -1177,7 +1177,7 @@ static inline int pci_msix_table_size(struct pci_dev *dev)`
`1177`	`1177`	`static inline int pci_enable_msix(struct pci_dev *dev,`
`1178`	`1178`	`struct msix_entry *entries, int nvec)`
`1179`	`1179`	`{`
`1180`		`- return -1;`
	`1180`	`+ return -ENOSYS;`
`1181`	`1181`	`}`
`1182`	`1182`
`1183`	`1183`	`static inline void pci_msix_shutdown(struct pci_dev *dev)`