wifi: libertas_tf: don't call kfree_skb() under spin_lock_irqsave()

Yang Yingliang · Sasha Levin · commit 8f38006a5607 · 2023-03-10T11:38:14.000Z
[ Upstream commit 9388ce9 ] It is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled. So replace kfree_skb() with dev_kfree_skb_irq() under spin_lock_irqsave(). Compile tested only. Fixes: fc75122 ("libertas_tf: use irqsave() in USB's complete callback") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: Kalle Valo <kvalo@kernel.org> Link: https://lore.kernel.org/r/20221207150008.111743-2-yangyingliang@huawei.com Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/net/wireless/marvell/libertas_tf/if_usb.c b/drivers/net/wireless/marvell/libertas_tf/if_usb.c
@@ -613,7 +613,7 @@ static inline void process_cmdrequest(int recvlength, uint8_t *recvbuff,
 	spin_lock_irqsave(&priv->driver_lock, flags);
 	memcpy(priv->cmd_resp_buff, recvbuff + MESSAGE_HEADER_LEN,
 	       recvlength - MESSAGE_HEADER_LEN);
-	kfree_skb(skb);
+	dev_kfree_skb_irq(skb);
 	lbtf_cmd_response_rx(priv);
 	spin_unlock_irqrestore(&priv->driver_lock, flags);
 }

Original file line number	Diff line number	Diff line change
`@@ -613,7 +613,7 @@ static inline void process_cmdrequest(int recvlength, uint8_t *recvbuff,`
`613`	`613`	`spin_lock_irqsave(&priv->driver_lock, flags);`
`614`	`614`	`memcpy(priv->cmd_resp_buff, recvbuff + MESSAGE_HEADER_LEN,`
`615`	`615`	`recvlength - MESSAGE_HEADER_LEN);`
`616`		`- kfree_skb(skb);`
	`616`	`+ dev_kfree_skb_irq(skb);`
`617`	`617`	`lbtf_cmd_response_rx(priv);`
`618`	`618`	`spin_unlock_irqrestore(&priv->driver_lock, flags);`
`619`	`619`	`}`