Skip to content

Commit 8fc5ec7

Browse files
rupranralfbaechle
authored andcommitted
MIPS: mm: Remove dead macro definitions
In commit c441d4a ("MIPS: mm: Only build one microassembler that is suitable"), the Makefile at arch/mips/mm was rewritten to only build the "right" microassembler file, depending on whether CONFIG_CPU_MICROMIPS is set or not. In the files, however, there are still preprocessor definitions depending on CONFIG_CPU_MICROMIPS. The #ifdef around them can now never evaluate to true, so let's remove them altogether. This inconsistency was found using the undertaker-checkpatch tool. Signed-off-by: Andreas Ruprecht <rupran@einserver.de> Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org> Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Cc: Valentin Rothberg <valentinrothberg@gmail.com> Cc: Paul Bolle <pebolle@tiscali.nl> Patchwork: https://patchwork.linux-mips.org/patch/9267/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
1 parent 64b139f commit 8fc5ec7

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

arch/mips/mm/uasm-micromips.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,6 @@
3838
| (e) << RE_SH \
3939
| (f) << FUNC_SH)
4040

41-
/* Define these when we are not the ISA the kernel is being compiled with. */
42-
#ifndef CONFIG_CPU_MICROMIPS
43-
#define MM_uasm_i_b(buf, off) ISAOPC(_beq)(buf, 0, 0, off)
44-
#define MM_uasm_i_beqz(buf, rs, off) ISAOPC(_beq)(buf, rs, 0, off)
45-
#define MM_uasm_i_beqzl(buf, rs, off) ISAOPC(_beql)(buf, rs, 0, off)
46-
#define MM_uasm_i_bnez(buf, rs, off) ISAOPC(_bne)(buf, rs, 0, off)
47-
#endif
48-
4941
#include "uasm.c"
5042

5143
static struct insn insn_table_MM[] = {

arch/mips/mm/uasm-mips.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,6 @@
4646
| (d) << SIMM9_SH \
4747
| (e) << FUNC_SH)
4848

49-
/* Define these when we are not the ISA the kernel is being compiled with. */
50-
#ifdef CONFIG_CPU_MICROMIPS
51-
#define CL_uasm_i_b(buf, off) ISAOPC(_beq)(buf, 0, 0, off)
52-
#define CL_uasm_i_beqz(buf, rs, off) ISAOPC(_beq)(buf, rs, 0, off)
53-
#define CL_uasm_i_beqzl(buf, rs, off) ISAOPC(_beql)(buf, rs, 0, off)
54-
#define CL_uasm_i_bnez(buf, rs, off) ISAOPC(_bne)(buf, rs, 0, off)
55-
#endif
56-
5749
#include "uasm.c"
5850

5951
static struct insn insn_table[] = {

0 commit comments

Comments
 (0)