s390/qeth: remove unused fallback in Layer3's MAC code

julianwiedmann · davem330 · commit 9168f5ae3837 · 2018-11-08T17:22:24.000-08:00
If the CREATE ADDR sent by qeth_l3_iqd_read_initial_mac() fails, its
callback sets a random MAC address on the net_device. The error then
propagates back, and qeth_l3_setup_netdev() bails out without
registering the net_device.

Any subsequent call to qeth_l3_setup_netdev() will then attempt a fresh
CREATE ADDR which either 1) also fails, or 2) sets a proper MAC address
on the net_device. Consequently, the net_device will never be registered
with a random MAC and we can drop the fallback code.

Signed-off-by: Julian Wiedmann &lt;jwi@linux.ibm.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
@@ -949,9 +949,6 @@ static int qeth_l3_iqd_read_initial_mac_cb(struct qeth_card *card,
 	if (cmd->hdr.return_code == 0)
 		ether_addr_copy(card->dev->dev_addr,
 				cmd->data.create_destroy_addr.unique_id);
-	else
-		eth_random_addr(card->dev->dev_addr);
-
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -949,9 +949,6 @@ static int qeth_l3_iqd_read_initial_mac_cb(struct qeth_card *card,`
`949`	`949`	`if (cmd->hdr.return_code == 0)`
`950`	`950`	`ether_addr_copy(card->dev->dev_addr,`
`951`	`951`	`cmd->data.create_destroy_addr.unique_id);`
`952`		`- else`
`953`		`- eth_random_addr(card->dev->dev_addr);`
`954`		`-`
`955`	`952`	`return 0;`
`956`	`953`	`}`
`957`	`954`