kvm: x86: Add payload operands to kvm_multiple_exception

jsmattsonjr · bonzini · commit 91e86d225ef3 · 2018-10-17T19:07:42.000+02:00
kvm_multiple_exception now takes two additional operands: has_payload
and payload, so that updates to CR2 (and DR6 under VMX) can be delayed
until the exception is delivered. This is necessary to properly
emulate VMX or SVM hardware behavior for nested virtualization.

The new behavior is triggered by
vcpu-&gt;kvm-&gt;arch.exception_payload_enabled, which will (later) be set
by a new per-VM capability, KVM_CAP_EXCEPTION_PAYLOAD.

Reported-by: Jim Mattson &lt;jmattson@google.com&gt;
Suggested-by: Paolo Bonzini &lt;pbonzini@redhat.com&gt;
Signed-off-by: Jim Mattson &lt;jmattson@google.com&gt;
Signed-off-by: Paolo Bonzini &lt;pbonzini@redhat.com&gt;
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
@@ -402,7 +402,7 @@ static int exception_type(int vector)
 
 static void kvm_multiple_exception(struct kvm_vcpu *vcpu,
 		unsigned nr, bool has_error, u32 error_code,
-		bool reinject)
+	        bool has_payload, unsigned long payload, bool reinject)
 {
 	u32 prev_nr;
 	int class1, class2;
@@ -424,15 +424,23 @@ static void kvm_multiple_exception(struct kvm_vcpu *vcpu,
 			 */
 			WARN_ON_ONCE(vcpu->arch.exception.pending);
 			vcpu->arch.exception.injected = true;
+			if (WARN_ON_ONCE(has_payload)) {
+				/*
+				 * A reinjected event has already
+				 * delivered its payload.
+				 */
+				has_payload = false;
+				payload = 0;
+			}
 		} else {
 			vcpu->arch.exception.pending = true;
 			vcpu->arch.exception.injected = false;
 		}
 		vcpu->arch.exception.has_error_code = has_error;
 		vcpu->arch.exception.nr = nr;
 		vcpu->arch.exception.error_code = error_code;
-		vcpu->arch.exception.has_payload = false;
-		vcpu->arch.exception.payload = 0;
+		vcpu->arch.exception.has_payload = has_payload;
+		vcpu->arch.exception.payload = payload;
 		return;
 	}
 
@@ -468,13 +476,13 @@ static void kvm_multiple_exception(struct kvm_vcpu *vcpu,
 
 void kvm_queue_exception(struct kvm_vcpu *vcpu, unsigned nr)
 {
-	kvm_multiple_exception(vcpu, nr, false, 0, false);
+	kvm_multiple_exception(vcpu, nr, false, 0, false, 0, false);
 }
 EXPORT_SYMBOL_GPL(kvm_queue_exception);
 
 void kvm_requeue_exception(struct kvm_vcpu *vcpu, unsigned nr)
 {
-	kvm_multiple_exception(vcpu, nr, false, 0, true);
+	kvm_multiple_exception(vcpu, nr, false, 0, false, 0, true);
 }
 EXPORT_SYMBOL_GPL(kvm_requeue_exception);
 
@@ -521,13 +529,13 @@ EXPORT_SYMBOL_GPL(kvm_inject_nmi);
 
 void kvm_queue_exception_e(struct kvm_vcpu *vcpu, unsigned nr, u32 error_code)
 {
-	kvm_multiple_exception(vcpu, nr, true, error_code, false);
+	kvm_multiple_exception(vcpu, nr, true, error_code, false, 0, false);
 }
 EXPORT_SYMBOL_GPL(kvm_queue_exception_e);
 
 void kvm_requeue_exception_e(struct kvm_vcpu *vcpu, unsigned nr, u32 error_code)
 {
-	kvm_multiple_exception(vcpu, nr, true, error_code, true);
+	kvm_multiple_exception(vcpu, nr, true, error_code, false, 0, true);
 }
 EXPORT_SYMBOL_GPL(kvm_requeue_exception_e);
 

Original file line number	Diff line number	Diff line change
`@@ -402,7 +402,7 @@ static int exception_type(int vector)`
`402`	`402`
`403`	`403`	`static void kvm_multiple_exception(struct kvm_vcpu *vcpu,`
`404`	`404`	`unsigned nr, bool has_error, u32 error_code,`
`405`		`- bool reinject)`
	`405`	`+ bool has_payload, unsigned long payload, bool reinject)`
`406`	`406`	`{`
`407`	`407`	`u32 prev_nr;`
`408`	`408`	`int class1, class2;`
`@@ -424,15 +424,23 @@ static void kvm_multiple_exception(struct kvm_vcpu *vcpu,`
`424`	`424`	`*/`
`425`	`425`	`WARN_ON_ONCE(vcpu->arch.exception.pending);`
`426`	`426`	`vcpu->arch.exception.injected = true;`
	`427`	`+ if (WARN_ON_ONCE(has_payload)) {`
	`428`	`+ /*`
	`429`	`+ * A reinjected event has already`
	`430`	`+ * delivered its payload.`
	`431`	`+ */`
	`432`	`+ has_payload = false;`
	`433`	`+ payload = 0;`
	`434`	`+ }`
`427`	`435`	`} else {`
`428`	`436`	`vcpu->arch.exception.pending = true;`
`429`	`437`	`vcpu->arch.exception.injected = false;`
`430`	`438`	`}`
`431`	`439`	`vcpu->arch.exception.has_error_code = has_error;`
`432`	`440`	`vcpu->arch.exception.nr = nr;`
`433`	`441`	`vcpu->arch.exception.error_code = error_code;`
`434`		`- vcpu->arch.exception.has_payload = false;`
`435`		`- vcpu->arch.exception.payload = 0;`
	`442`	`+ vcpu->arch.exception.has_payload = has_payload;`
	`443`	`+ vcpu->arch.exception.payload = payload;`
`436`	`444`	`return;`
`437`	`445`	`}`
`438`	`446`
`@@ -468,13 +476,13 @@ static void kvm_multiple_exception(struct kvm_vcpu *vcpu,`
`468`	`476`
`469`	`477`	`void kvm_queue_exception(struct kvm_vcpu *vcpu, unsigned nr)`
`470`	`478`	`{`
`471`		`- kvm_multiple_exception(vcpu, nr, false, 0, false);`
	`479`	`+ kvm_multiple_exception(vcpu, nr, false, 0, false, 0, false);`
`472`	`480`	`}`
`473`	`481`	`EXPORT_SYMBOL_GPL(kvm_queue_exception);`
`474`	`482`
`475`	`483`	`void kvm_requeue_exception(struct kvm_vcpu *vcpu, unsigned nr)`
`476`	`484`	`{`
`477`		`- kvm_multiple_exception(vcpu, nr, false, 0, true);`
	`485`	`+ kvm_multiple_exception(vcpu, nr, false, 0, false, 0, true);`
`478`	`486`	`}`
`479`	`487`	`EXPORT_SYMBOL_GPL(kvm_requeue_exception);`
`480`	`488`
`@@ -521,13 +529,13 @@ EXPORT_SYMBOL_GPL(kvm_inject_nmi);`
`521`	`529`
`522`	`530`	`void kvm_queue_exception_e(struct kvm_vcpu *vcpu, unsigned nr, u32 error_code)`
`523`	`531`	`{`
`524`		`- kvm_multiple_exception(vcpu, nr, true, error_code, false);`
	`532`	`+ kvm_multiple_exception(vcpu, nr, true, error_code, false, 0, false);`
`525`	`533`	`}`
`526`	`534`	`EXPORT_SYMBOL_GPL(kvm_queue_exception_e);`
`527`	`535`
`528`	`536`	`void kvm_requeue_exception_e(struct kvm_vcpu *vcpu, unsigned nr, u32 error_code)`
`529`	`537`	`{`
`530`		`- kvm_multiple_exception(vcpu, nr, true, error_code, true);`
	`538`	`+ kvm_multiple_exception(vcpu, nr, true, error_code, false, 0, true);`
`531`	`539`	`}`
`532`	`540`	`EXPORT_SYMBOL_GPL(kvm_requeue_exception_e);`
`533`	`541`