rtc: Expire alarms after the time is set.

neilbrown · johnstultz-work · commit 93b2ec0128c4 · 2011-12-13T12:26:11.000-08:00
If the alarm time programming in the rtc is ever in the past, it won't fire,
and any other alarm will be queued after it so they won't fire either.

So any time that the alarm might be in the past, we need to trigger
the irq handler to ensure the old alarm is cleared and the timer queue
is fully in the future.

This can happen:
 - when we first initialise the alarm
 - when we set the time in the rtc.

so follow both of these by scheduling the timer work function.

CC: stable@kernel.org
Signed-off-by: NeilBrown &lt;neilb@suse.de&gt;
[Also catch set_mmss case -jstultz]
Signed-off-by: John Stultz &lt;john.stultz@linaro.org&gt;
diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c
@@ -73,6 +73,8 @@ int rtc_set_time(struct rtc_device *rtc, struct rtc_time *tm)
 		err = -EINVAL;
 
 	mutex_unlock(&rtc->ops_lock);
+	/* A timer might have just expired */
+	schedule_work(&rtc->irqwork);
 	return err;
 }
 EXPORT_SYMBOL_GPL(rtc_set_time);
@@ -112,6 +114,8 @@ int rtc_set_mmss(struct rtc_device *rtc, unsigned long secs)
 		err = -EINVAL;
 
 	mutex_unlock(&rtc->ops_lock);
+	/* A timer might have just expired */
+	schedule_work(&rtc->irqwork);
 
 	return err;
 }
@@ -403,6 +407,8 @@ int rtc_initialize_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm)
 		timerqueue_add(&rtc->timerqueue, &rtc->aie_timer.node);
 	}
 	mutex_unlock(&rtc->ops_lock);
+	/* maybe that was in the past.*/
+	schedule_work(&rtc->irqwork);
 	return err;
 }
 EXPORT_SYMBOL_GPL(rtc_initialize_alarm);

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,8 @@ int rtc_set_time(struct rtc_device rtc, struct rtc_time tm)`
`73`	`73`	`err = -EINVAL;`
`74`	`74`
`75`	`75`	`mutex_unlock(&rtc->ops_lock);`
	`76`	`+ /* A timer might have just expired */`
	`77`	`+ schedule_work(&rtc->irqwork);`
`76`	`78`	`return err;`
`77`	`79`	`}`
`78`	`80`	`EXPORT_SYMBOL_GPL(rtc_set_time);`
`@@ -112,6 +114,8 @@ int rtc_set_mmss(struct rtc_device *rtc, unsigned long secs)`
`112`	`114`	`err = -EINVAL;`
`113`	`115`
`114`	`116`	`mutex_unlock(&rtc->ops_lock);`
	`117`	`+ /* A timer might have just expired */`
	`118`	`+ schedule_work(&rtc->irqwork);`
`115`	`119`
`116`	`120`	`return err;`
`117`	`121`	`}`
`@@ -403,6 +407,8 @@ int rtc_initialize_alarm(struct rtc_device rtc, struct rtc_wkalrm alarm)`
`403`	`407`	`timerqueue_add(&rtc->timerqueue, &rtc->aie_timer.node);`
`404`	`408`	`}`
`405`	`409`	`mutex_unlock(&rtc->ops_lock);`
	`410`	`+ /* maybe that was in the past.*/`
	`411`	`+ schedule_work(&rtc->irqwork);`
`406`	`412`	`return err;`
`407`	`413`	`}`
`408`	`414`	`EXPORT_SYMBOL_GPL(rtc_initialize_alarm);`