Skip to content

Commit 93f8be2

Browse files
ahunter6acmel
authored andcommitted
perf intel-pt: Add more event information to debug log
More event information is useful for debugging, especially MMAP events. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Link: http://lkml.kernel.org/r/20181105073505.8129-2-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 35fa1ce commit 93f8be2

File tree

3 files changed

+19
-3
lines changed

3 files changed

+19
-3
lines changed

tools/perf/util/intel-pt-decoder/intel-pt-log.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,11 @@ static FILE *f;
3131
static char log_name[MAX_LOG_NAME];
3232
bool intel_pt_enable_logging;
3333

34+
void *intel_pt_log_fp(void)
35+
{
36+
return f;
37+
}
38+
3439
void intel_pt_log_enable(void)
3540
{
3641
intel_pt_enable_logging = true;

tools/perf/util/intel-pt-decoder/intel-pt-log.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
struct intel_pt_pkt;
2424

25+
void *intel_pt_log_fp(void);
2526
void intel_pt_log_enable(void);
2627
void intel_pt_log_disable(void);
2728
void intel_pt_log_set_name(const char *name);

tools/perf/util/intel-pt.c

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,16 @@ static void intel_pt_dump_event(struct intel_pt *pt, unsigned char *buf,
206206
intel_pt_dump(pt, buf, len);
207207
}
208208

209+
static void intel_pt_log_event(union perf_event *event)
210+
{
211+
FILE *f = intel_pt_log_fp();
212+
213+
if (!intel_pt_enable_logging || !f)
214+
return;
215+
216+
perf_event__fprintf(event, f);
217+
}
218+
209219
static int intel_pt_do_fix_overlap(struct intel_pt *pt, struct auxtrace_buffer *a,
210220
struct auxtrace_buffer *b)
211221
{
@@ -2010,9 +2020,9 @@ static int intel_pt_process_event(struct perf_session *session,
20102020
event->header.type == PERF_RECORD_SWITCH_CPU_WIDE)
20112021
err = intel_pt_context_switch(pt, event, sample);
20122022

2013-
intel_pt_log("event %s (%u): cpu %d time %"PRIu64" tsc %#"PRIx64"\n",
2014-
perf_event__name(event->header.type), event->header.type,
2015-
sample->cpu, sample->time, timestamp);
2023+
intel_pt_log("event %u: cpu %d time %"PRIu64" tsc %#"PRIx64" ",
2024+
event->header.type, sample->cpu, sample->time, timestamp);
2025+
intel_pt_log_event(event);
20162026

20172027
return err;
20182028
}

0 commit comments

Comments
 (0)