drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers()

Dan Carpenter · ogabbay · commit 93fce954427e · 2016-03-15T14:09:37.000+02:00
At the end of the function we expect "status" to be zero, but it's either -EINVAL or uninitialized. Fixes: 788bf83 ('drm/amdkfd: Add wave control operation to debugger') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
@@ -513,7 +513,7 @@ static int dbgdev_wave_control_set_registers(
 				union SQ_CMD_BITS *in_reg_sq_cmd,
 				union GRBM_GFX_INDEX_BITS *in_reg_gfx_index)
 {
-	int status;
+	int status = 0;
 	union SQ_CMD_BITS reg_sq_cmd;
 	union GRBM_GFX_INDEX_BITS reg_gfx_index;
 	struct HsaDbgWaveMsgAMDGen2 *pMsg;

Original file line number	Diff line number	Diff line change
`@@ -513,7 +513,7 @@ static int dbgdev_wave_control_set_registers(`
`513`	`513`	`union SQ_CMD_BITS *in_reg_sq_cmd,`
`514`	`514`	`union GRBM_GFX_INDEX_BITS *in_reg_gfx_index)`
`515`	`515`	`{`
`516`		`- int status;`
	`516`	`+ int status = 0;`
`517`	`517`	`union SQ_CMD_BITS reg_sq_cmd;`
`518`	`518`	`union GRBM_GFX_INDEX_BITS reg_gfx_index;`
`519`	`519`	`struct HsaDbgWaveMsgAMDGen2 *pMsg;`