Skip to content

Commit 958c13c

Browse files
author
Al Viro
committed
make aio_read()/aio_write() return int
that ssize_t is a rudiment of earlier calling conventions; it's been used only to pass 0 and -E... since last autumn. Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent af5c72b commit 958c13c

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

fs/aio.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1513,13 +1513,13 @@ static inline void aio_rw_done(struct kiocb *req, ssize_t ret)
15131513
}
15141514
}
15151515

1516-
static ssize_t aio_read(struct kiocb *req, const struct iocb *iocb,
1516+
static int aio_read(struct kiocb *req, const struct iocb *iocb,
15171517
bool vectored, bool compat)
15181518
{
15191519
struct iovec inline_vecs[UIO_FASTIOV], *iovec = inline_vecs;
15201520
struct iov_iter iter;
15211521
struct file *file;
1522-
ssize_t ret;
1522+
int ret;
15231523

15241524
ret = aio_prep_rw(req, iocb);
15251525
if (ret)
@@ -1541,13 +1541,13 @@ static ssize_t aio_read(struct kiocb *req, const struct iocb *iocb,
15411541
return ret;
15421542
}
15431543

1544-
static ssize_t aio_write(struct kiocb *req, const struct iocb *iocb,
1544+
static int aio_write(struct kiocb *req, const struct iocb *iocb,
15451545
bool vectored, bool compat)
15461546
{
15471547
struct iovec inline_vecs[UIO_FASTIOV], *iovec = inline_vecs;
15481548
struct iov_iter iter;
15491549
struct file *file;
1550-
ssize_t ret;
1550+
int ret;
15511551

15521552
ret = aio_prep_rw(req, iocb);
15531553
if (ret)
@@ -1710,7 +1710,7 @@ aio_poll_queue_proc(struct file *file, struct wait_queue_head *head,
17101710
add_wait_queue(head, &pt->iocb->poll.wait);
17111711
}
17121712

1713-
static ssize_t aio_poll(struct aio_kiocb *aiocb, const struct iocb *iocb)
1713+
static int aio_poll(struct aio_kiocb *aiocb, const struct iocb *iocb)
17141714
{
17151715
struct kioctx *ctx = aiocb->ki_ctx;
17161716
struct poll_iocb *req = &aiocb->poll;
@@ -1775,7 +1775,7 @@ static int __io_submit_one(struct kioctx *ctx, const struct iocb *iocb,
17751775
struct iocb __user *user_iocb, bool compat)
17761776
{
17771777
struct aio_kiocb *req;
1778-
ssize_t ret;
1778+
int ret;
17791779

17801780
/* enforce forwards compatibility on users */
17811781
if (unlikely(iocb->aio_reserved2)) {

0 commit comments

Comments
 (0)