mdio_bus: Remove unneeded gpiod NULL check

Fabio Estevam · davem330 · commit 95b80bf3db03 · 2017-07-17T16:57:04.000-07:00
The gpiod API checks for NULL descriptors, so there is no need to
duplicate the check in the driver.

Signed-off-by: Fabio Estevam &lt;fabio.estevam@nxp.com&gt;
Reviewed-by: Andrew Lunn &lt;andrew@lunn.ch&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
@@ -399,8 +399,7 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner)
 	}
 
 	/* Put PHYs in RESET to save power */
-	if (bus->reset_gpiod)
-		gpiod_set_value_cansleep(bus->reset_gpiod, 1);
+	gpiod_set_value_cansleep(bus->reset_gpiod, 1);
 
 	device_del(&bus->dev);
 	return err;
@@ -425,8 +424,7 @@ void mdiobus_unregister(struct mii_bus *bus)
 	}
 
 	/* Put PHYs in RESET to save power */
-	if (bus->reset_gpiod)
-		gpiod_set_value_cansleep(bus->reset_gpiod, 1);
+	gpiod_set_value_cansleep(bus->reset_gpiod, 1);
 
 	device_del(&bus->dev);
 }

Original file line number	Diff line number	Diff line change
`@@ -399,8 +399,7 @@ int __mdiobus_register(struct mii_bus bus, struct module owner)`
`399`	`399`	`}`
`400`	`400`
`401`	`401`	`/* Put PHYs in RESET to save power */`
`402`		`- if (bus->reset_gpiod)`
`403`		`- gpiod_set_value_cansleep(bus->reset_gpiod, 1);`
	`402`	`+ gpiod_set_value_cansleep(bus->reset_gpiod, 1);`
`404`	`403`
`405`	`404`	`device_del(&bus->dev);`
`406`	`405`	`return err;`
`@@ -425,8 +424,7 @@ void mdiobus_unregister(struct mii_bus *bus)`
`425`	`424`	`}`
`426`	`425`
`427`	`426`	`/* Put PHYs in RESET to save power */`
`428`		`- if (bus->reset_gpiod)`
`429`		`- gpiod_set_value_cansleep(bus->reset_gpiod, 1);`
	`427`	`+ gpiod_set_value_cansleep(bus->reset_gpiod, 1);`
`430`	`428`
`431`	`429`	`device_del(&bus->dev);`
`432`	`430`	`}`