ext4: track writeback errors using the generic tracking infrastructure

tytso · tytso · commit 95cb67138746 · 2018-12-31T00:11:07.000-05:00
We already using mapping_set_error() in fs/ext4/page_io.c, so all we
need to do is to use file_check_and_advance_wb_err() when handling
fsync() requests in ext4_sync_file().

Signed-off-by: Theodore Ts'o &lt;tytso@mit.edu&gt;
Cc: stable@kernel.org
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
@@ -164,6 +164,9 @@ int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
 			ret = err;
 	}
 out:
+	err = file_check_and_advance_wb_err(file);
+	if (ret == 0)
+		ret = err;
 	trace_ext4_sync_file_exit(inode, ret);
 	return ret;
 }

Original file line number	Diff line number	Diff line change
`@@ -164,6 +164,9 @@ int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync)`
`164`	`164`	`ret = err;`
`165`	`165`	`}`
`166`	`166`	`out:`
	`167`	`+ err = file_check_and_advance_wb_err(file);`
	`168`	`+ if (ret == 0)`
	`169`	`+ ret = err;`
`167`	`170`	`trace_ext4_sync_file_exit(inode, ret);`
`168`	`171`	`return ret;`
`169`	`172`	`}`