Skip to content

Commit 9727771

Browse files
khoroshilovdvhart
authored andcommitted
platform/x86: wmi: Fix error handling in acpi_wmi_init()
The order of resource deallocations is messed up in acpi_wmi_init(). It should be vice versa. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
1 parent a00c696 commit 9727771

File tree

1 file changed

+3
-3
lines changed
  • drivers/platform/x86

1 file changed

+3
-3
lines changed

drivers/platform/x86/wmi.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1252,12 +1252,12 @@ static int __init acpi_wmi_init(void)
12521252

12531253
return 0;
12541254

1255-
err_unreg_class:
1256-
class_unregister(&wmi_bus_class);
1257-
12581255
err_unreg_bus:
12591256
bus_unregister(&wmi_bus_type);
12601257

1258+
err_unreg_class:
1259+
class_unregister(&wmi_bus_class);
1260+
12611261
return error;
12621262
}
12631263

0 commit comments

Comments
 (0)