Skip to content

Commit 989983e

Browse files
jk-ozlabsgregkh
authored andcommitted
serial/aspeed-vuart: Implement rx throttling
The aspeed VUART runs at LPC bus frequency, rather than being restricted to a typical UART baud rate. This means that the VUART can receive a lot of data, which can overrun tty flip buffers, and/or cause a large amount of interrupt traffic. This change implements the uart_port->throttle & unthrottle callbacks, implemented by disabling the receiver line status & received data available IRQs. Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Tested-by: Eddie James <eajames@linux.vnet.ibm.com> Tested-by: Joel Stanley <joel@jms.id.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent ebbaf9a commit 989983e

File tree

1 file changed

+27
-0
lines changed

1 file changed

+27
-0
lines changed

drivers/tty/serial/8250/8250_aspeed_vuart.c

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,30 @@ static void aspeed_vuart_shutdown(struct uart_port *uart_port)
179179
serial8250_do_shutdown(uart_port);
180180
}
181181

182+
static void aspeed_vuart_set_throttle(struct uart_port *port, bool throttle)
183+
{
184+
unsigned char irqs = UART_IER_RLSI | UART_IER_RDI;
185+
struct uart_8250_port *up = up_to_u8250p(port);
186+
unsigned long flags;
187+
188+
spin_lock_irqsave(&port->lock, flags);
189+
up->ier &= ~irqs;
190+
if (!throttle)
191+
up->ier |= irqs;
192+
serial_out(up, UART_IER, up->ier);
193+
spin_unlock_irqrestore(&port->lock, flags);
194+
}
195+
196+
static void aspeed_vuart_throttle(struct uart_port *port)
197+
{
198+
aspeed_vuart_set_throttle(port, true);
199+
}
200+
201+
static void aspeed_vuart_unthrottle(struct uart_port *port)
202+
{
203+
aspeed_vuart_set_throttle(port, false);
204+
}
205+
182206
static int aspeed_vuart_probe(struct platform_device *pdev)
183207
{
184208
struct uart_8250_port port;
@@ -208,6 +232,9 @@ static int aspeed_vuart_probe(struct platform_device *pdev)
208232
port.port.mapsize = resource_size(res);
209233
port.port.startup = aspeed_vuart_startup;
210234
port.port.shutdown = aspeed_vuart_shutdown;
235+
port.port.throttle = aspeed_vuart_throttle;
236+
port.port.unthrottle = aspeed_vuart_unthrottle;
237+
port.port.status = UPSTAT_SYNC_FIFO;
211238
port.port.dev = &pdev->dev;
212239

213240
rc = sysfs_create_group(&vuart->dev->kobj, &aspeed_vuart_attr_group);

0 commit comments

Comments
 (0)