Skip to content

Commit 9c1c3fa

Browse files
Suresh SiddhaH. Peter Anvin
authored andcommitted
x86, kvm: use kernel_fpu_begin/end() in kvm_load/put_guest_fpu()
kvm's guest fpu save/restore should be wrapped around kernel_fpu_begin/end(). This will avoid for example taking a DNA in kvm_load_guest_fpu() when it tries to load the fpu immediately after doing unlazy_fpu() on the host side. More importantly this will prevent the host process fpu from being corrupted. Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com> Link: http://lkml.kernel.org/r/1345842782-24175-4-git-send-email-suresh.b.siddha@intel.com Cc: Avi Kivity <avi@redhat.com> Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
1 parent 377ffbc commit 9c1c3fa

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

arch/x86/kvm/x86.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5972,7 +5972,7 @@ void kvm_load_guest_fpu(struct kvm_vcpu *vcpu)
59725972
*/
59735973
kvm_put_guest_xcr0(vcpu);
59745974
vcpu->guest_fpu_loaded = 1;
5975-
unlazy_fpu(current);
5975+
kernel_fpu_begin();
59765976
fpu_restore_checking(&vcpu->arch.guest_fpu);
59775977
trace_kvm_fpu(1);
59785978
}
@@ -5986,6 +5986,7 @@ void kvm_put_guest_fpu(struct kvm_vcpu *vcpu)
59865986

59875987
vcpu->guest_fpu_loaded = 0;
59885988
fpu_save_init(&vcpu->arch.guest_fpu);
5989+
kernel_fpu_end();
59895990
++vcpu->stat.fpu_reload;
59905991
kvm_make_request(KVM_REQ_DEACTIVATE_FPU, vcpu);
59915992
trace_kvm_fpu(0);

0 commit comments

Comments
 (0)