hwrng: omap - Move probe function to .devinit.text

Uwe Kleine-König · herbertx · commit 9f171adc192f · 2009-06-02T14:04:21.000+10:00
A pointer to omap_rng_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König &lt;u.kleine-koenig@pengutronix.de&gt;
Cc: Russell King &lt;rmk+kernel@arm.linux.org.uk&gt;
Cc: David Brownell &lt;dbrownell@users.sourceforge.net&gt;
Cc: Patrick McHardy &lt;kaber@trash.net&gt;
Cc: Jan Engelhardt &lt;jengelh@gmx.de&gt;
Cc: Michael Buesch &lt;mb@bu3sch.de&gt;
Cc: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c
@@ -89,7 +89,7 @@ static struct hwrng omap_rng_ops = {
 	.data_read	= omap_rng_data_read,
 };
 
-static int __init omap_rng_probe(struct platform_device *pdev)
+static int __devinit omap_rng_probe(struct platform_device *pdev)
 {
 	struct resource *res, *mem;
 	int ret;

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ static struct hwrng omap_rng_ops = {`
`89`	`89`	`.data_read = omap_rng_data_read,`
`90`	`90`	`};`
`91`	`91`
`92`		`-static int __init omap_rng_probe(struct platform_device *pdev)`
	`92`	`+static int __devinit omap_rng_probe(struct platform_device *pdev)`
`93`	`93`	`{`
`94`	`94`	`struct resource res, mem;`
`95`	`95`	`int ret;`