Skip to content

Commit 9f81270

Browse files
Hidehiro Kawaicminyard
authored andcommitted
ipmi: Fix a problem that messages are not issued in run_to_completion mode
start_next_msg() issues a message placed in smi_info->waiting_msg if it is non-NULL. However, sender() sets a message to smi_info->curr_msg and NULL to smi_info->waiting_msg in the context of run_to_completion mode. As the result, it leads an infinite loop by waiting the completion of unissued message when leaving dying message after kernel panic. sender() should set the message to smi_info->waiting_msg not curr_msg. Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com> Signed-off-by: Corey Minyard <cminyard@mvista.com>
1 parent a182a4b commit 9f81270

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/char/ipmi/ipmi_si_intf.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -942,8 +942,7 @@ static void sender(void *send_info,
942942
* If we are running to completion, start it and run
943943
* transactions until everything is clear.
944944
*/
945-
smi_info->curr_msg = msg;
946-
smi_info->waiting_msg = NULL;
945+
smi_info->waiting_msg = msg;
947946

948947
/*
949948
* Run to completion means we are single-threaded, no

0 commit comments

Comments
 (0)