Skip to content

Commit a1f1e61

Browse files
committed
drm/i915: Readout and check csc_mode
Add the missing readout and PIPE_CONF_CHECK() for csc_mode. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190218193137.22914-2-ville.syrjala@linux.intel.com Reviewed-by: Uma Shankar <uma.shankar@intel.com>
1 parent daeaaef commit a1f1e61

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

drivers/gpu/drm/i915/intel_color.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -788,6 +788,8 @@ int intel_color_check(struct intel_crtc_state *crtc_state)
788788
if (ret)
789789
return ret;
790790

791+
crtc_state->csc_mode = 0;
792+
791793
/* Always allow legacy gamma LUT with no further checking. */
792794
if (!crtc_state->gamma_enable ||
793795
crtc_state_is_legacy_gamma(crtc_state)) {
@@ -814,8 +816,6 @@ int intel_color_check(struct intel_crtc_state *crtc_state)
814816
else
815817
crtc_state->gamma_mode = GAMMA_MODE_MODE_8BIT;
816818

817-
crtc_state->csc_mode = 0;
818-
819819
if (INTEL_GEN(dev_priv) >= 11) {
820820
if (crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420 ||
821821
crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR444)

drivers/gpu/drm/i915/intel_display.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9288,6 +9288,8 @@ static bool ironlake_get_pipe_config(struct intel_crtc *crtc,
92889288
pipe_config->gamma_mode = (tmp & PIPECONF_GAMMA_MODE_MASK_ILK) >>
92899289
PIPECONF_GAMMA_MODE_SHIFT;
92909290

9291+
pipe_config->csc_mode = I915_READ(PIPE_CSC_MODE(crtc->pipe));
9292+
92919293
i9xx_get_pipe_color_config(pipe_config);
92929294

92939295
if (I915_READ(PCH_TRANSCONF(crtc->pipe)) & TRANS_ENABLE) {
@@ -9923,6 +9925,8 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc,
99239925

99249926
pipe_config->gamma_mode = I915_READ(GAMMA_MODE(crtc->pipe));
99259927

9928+
pipe_config->csc_mode = I915_READ(PIPE_CSC_MODE(crtc->pipe));
9929+
99269930
if (INTEL_GEN(dev_priv) >= 9) {
99279931
u32 tmp = I915_READ(SKL_BOTTOM_COLOR(crtc->pipe));
99289932

@@ -12234,6 +12238,7 @@ intel_pipe_config_compare(struct drm_i915_private *dev_priv,
1223412238
PIPE_CONF_CHECK_CLOCK_FUZZY(pixel_rate);
1223512239

1223612240
PIPE_CONF_CHECK_X(gamma_mode);
12241+
PIPE_CONF_CHECK_X(csc_mode);
1223712242
PIPE_CONF_CHECK_BOOL(gamma_enable);
1223812243
PIPE_CONF_CHECK_BOOL(csc_enable);
1223912244
}

0 commit comments

Comments
 (0)