drm/omap: displays: Don't cast dssdev to panel data unnecessarily

pinchartl · tomba · commit a25edf0ea6de · 2018-09-03T16:13:27.000+03:00
The connect handle of the analog TV and HDMI connectors casts the dssdev
to panel data only to then access fields of the panel data that are also
present in the dssdev. Remove the cast and use dssdev directly.

Signed-off-by: Laurent Pinchart &lt;laurent.pinchart@ideasonboard.com&gt;
Reviewed-by: Sebastian Reichel &lt;sebastian.reichel@collabora.co.uk&gt;
Signed-off-by: Tomi Valkeinen &lt;tomi.valkeinen@ti.com&gt;
diff --git a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
@@ -43,13 +43,12 @@ static const struct videomode tvc_pal_vm = {
 
 static int tvc_connect(struct omap_dss_device *dssdev)
 {
-	struct panel_drv_data *ddata = to_panel_data(dssdev);
 	struct omap_dss_device *src;
 	int r;
 
-	src = omapdss_of_find_connected_device(ddata->dev->of_node, 0);
+	src = omapdss_of_find_connected_device(dssdev->dev->of_node, 0);
 	if (IS_ERR_OR_NULL(src)) {
-		dev_err(ddata->dev, "failed to find video source\n");
+		dev_err(dssdev->dev, "failed to find video source\n");
 		return src ? PTR_ERR(src) : -EINVAL;
 	}
 
diff --git a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
@@ -53,13 +53,12 @@ struct panel_drv_data {
 
 static int hdmic_connect(struct omap_dss_device *dssdev)
 {
-	struct panel_drv_data *ddata = to_panel_data(dssdev);
 	struct omap_dss_device *src;
 	int r;
 
-	src = omapdss_of_find_connected_device(ddata->dev->of_node, 0);
+	src = omapdss_of_find_connected_device(dssdev->dev->of_node, 0);
 	if (IS_ERR_OR_NULL(src)) {
-		dev_err(ddata->dev, "failed to find video source\n");
+		dev_err(dssdev->dev, "failed to find video source\n");
 		return src ? PTR_ERR(src) : -EINVAL;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -43,13 +43,12 @@ static const struct videomode tvc_pal_vm = {`
`43`	`43`
`44`	`44`	`static int tvc_connect(struct omap_dss_device *dssdev)`
`45`	`45`	`{`
`46`		`- struct panel_drv_data *ddata = to_panel_data(dssdev);`
`47`	`46`	`struct omap_dss_device *src;`
`48`	`47`	`int r;`
`49`	`48`
`50`		`- src = omapdss_of_find_connected_device(ddata->dev->of_node, 0);`
	`49`	`+ src = omapdss_of_find_connected_device(dssdev->dev->of_node, 0);`
`51`	`50`	`if (IS_ERR_OR_NULL(src)) {`
`52`		`- dev_err(ddata->dev, "failed to find video source\n");`
	`51`	`+ dev_err(dssdev->dev, "failed to find video source\n");`
`53`	`52`	`return src ? PTR_ERR(src) : -EINVAL;`
`54`	`53`	`}`
`55`	`54`
Original file line number	Diff line number	Diff line change
`@@ -53,13 +53,12 @@ struct panel_drv_data {`
`53`	`53`
`54`	`54`	`static int hdmic_connect(struct omap_dss_device *dssdev)`
`55`	`55`	`{`
`56`		`- struct panel_drv_data *ddata = to_panel_data(dssdev);`
`57`	`56`	`struct omap_dss_device *src;`
`58`	`57`	`int r;`
`59`	`58`
`60`		`- src = omapdss_of_find_connected_device(ddata->dev->of_node, 0);`
	`59`	`+ src = omapdss_of_find_connected_device(dssdev->dev->of_node, 0);`
`61`	`60`	`if (IS_ERR_OR_NULL(src)) {`
`62`		`- dev_err(ddata->dev, "failed to find video source\n");`
	`61`	`+ dev_err(dssdev->dev, "failed to find video source\n");`
`63`	`62`	`return src ? PTR_ERR(src) : -EINVAL;`
`64`	`63`	`}`
`65`	`64`