inotify: stop kernel memory leak on file creation failure

eparis · eparis · commit a2ae4cc9a16e · 2010-12-07T16:14:22.000-05:00
If inotify_init is unable to allocate a new file for the new inotify
group we leak the new group.  This patch drops the reference on the
group on file allocation failure.

Reported-by: Vegard Nossum &lt;vegard.nossum@gmail.com&gt;
cc: stable@kernel.org
Signed-off-by: Eric Paris &lt;eparis@redhat.com&gt;
diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c
@@ -752,6 +752,7 @@ SYSCALL_DEFINE1(inotify_init1, int, flags)
 	if (ret >= 0)
 		return ret;
 
+	fsnotify_put_group(group);
 	atomic_dec(&user->inotify_devs);
 out_free_uid:
 	free_uid(user);
