HID: intel-ish-hid: use put_device() instead of kfree()

ArvindYadavCs · Jiri Kosina · commit a4eb490a41a0 · 2018-04-26T14:36:43.000+02:00
Never directly free @dev after calling device_register(), even if it returned an error. Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c
@@ -418,7 +418,7 @@ static struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device *dev,
 		list_del(&device->device_link);
 		spin_unlock_irqrestore(&dev->device_list_lock, flags);
 		dev_err(dev->devc, "Failed to register ISHTP client device\n");
-		kfree(device);
+		put_device(&device->dev);
 		return NULL;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -418,7 +418,7 @@ static struct ishtp_cl_device ishtp_bus_add_device(struct ishtp_device dev,`
`418`	`418`	`list_del(&device->device_link);`
`419`	`419`	`spin_unlock_irqrestore(&dev->device_list_lock, flags);`
`420`	`420`	`dev_err(dev->devc, "Failed to register ISHTP client device\n");`
`421`		`- kfree(device);`
	`421`	`+ put_device(&device->dev);`
`422`	`422`	`return NULL;`
`423`	`423`	`}`
`424`	`424`